From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:37544 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757815AbeD0Vch (ORCPT ); Fri, 27 Apr 2018 17:32:37 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , open list Subject: Re: [PATCH v2 11/11] arm64: dts: r8a77965-salvator-xs: Enable DU external clocks and HDMI Date: Sat, 28 Apr 2018 00:32:49 +0300 Message-ID: <35470587.gVktJpfmq0@avalon> In-Reply-To: <20180427165722.19445-12-kieran.bingham+renesas@ideasonboard.com> References: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com> <20180427165722.19445-12-kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Friday, 27 April 2018 19:57:22 EEST Kieran Bingham wrote: > The DU1 external dot clock is provided by the fixed frequency clock > generator X21, while the DU0 and DU3 clocks are provided by the > programmable Versaclock6 clock generator. > > Enable the clocks, and the HDMI encoder for the M3-N Salvator-XS, and > hook it up to the HDMI connector > > Based on patches from Takeshi Kihara > > Signed-off-by: Kieran Bingham > --- > .../boot/dts/renesas/r8a77965-salvator-xs.dts | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts > b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts index > a83a00deed9e..dcf1849f1a67 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts > @@ -19,3 +19,32 @@ > reg = <0x0 0x48000000 0x0 0x78000000>; > }; > }; > + > +&du { > + clocks = <&cpg CPG_MOD 724>, > + <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 721>, > + <&cpg CPG_MOD 727>, > + <&versaclock6 1>, > + <&x21_clk>, > + <&versaclock6 2>; > + clock-names = "du.0", "du.1", "du.3", "lvds.0", > + "dclkin.0", "dclkin.1", "dclkin.3"; You should remove the LVDS clock from here too. Apart from that, Reviewed-by: Laurent Pinchart > +}; > + > +&hdmi0 { > + status = "okay"; > + > + ports { > + port@1 { > + reg = <1>; > + rcar_dw_hdmi0_out: endpoint { > + remote-endpoint = <&hdmi0_con>; > + }; > + }; > + }; > +}; > + > +&hdmi0_con { > + remote-endpoint = <&rcar_dw_hdmi0_out>; > +}; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Sat, 28 Apr 2018 00:32:49 +0300 Subject: [PATCH v2 11/11] arm64: dts: r8a77965-salvator-xs: Enable DU external clocks and HDMI In-Reply-To: <20180427165722.19445-12-kieran.bingham+renesas@ideasonboard.com> References: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com> <20180427165722.19445-12-kieran.bingham+renesas@ideasonboard.com> Message-ID: <35470587.gVktJpfmq0@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Kieran, Thank you for the patch. On Friday, 27 April 2018 19:57:22 EEST Kieran Bingham wrote: > The DU1 external dot clock is provided by the fixed frequency clock > generator X21, while the DU0 and DU3 clocks are provided by the > programmable Versaclock6 clock generator. > > Enable the clocks, and the HDMI encoder for the M3-N Salvator-XS, and > hook it up to the HDMI connector > > Based on patches from Takeshi Kihara > > Signed-off-by: Kieran Bingham > --- > .../boot/dts/renesas/r8a77965-salvator-xs.dts | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts > b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts index > a83a00deed9e..dcf1849f1a67 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts > @@ -19,3 +19,32 @@ > reg = <0x0 0x48000000 0x0 0x78000000>; > }; > }; > + > +&du { > + clocks = <&cpg CPG_MOD 724>, > + <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 721>, > + <&cpg CPG_MOD 727>, > + <&versaclock6 1>, > + <&x21_clk>, > + <&versaclock6 2>; > + clock-names = "du.0", "du.1", "du.3", "lvds.0", > + "dclkin.0", "dclkin.1", "dclkin.3"; You should remove the LVDS clock from here too. Apart from that, Reviewed-by: Laurent Pinchart > +}; > + > +&hdmi0 { > + status = "okay"; > + > + ports { > + port at 1 { > + reg = <1>; > + rcar_dw_hdmi0_out: endpoint { > + remote-endpoint = <&hdmi0_con>; > + }; > + }; > + }; > +}; > + > +&hdmi0_con { > + remote-endpoint = <&rcar_dw_hdmi0_out>; > +}; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 11/11] arm64: dts: r8a77965-salvator-xs: Enable DU external clocks and HDMI Date: Sat, 28 Apr 2018 00:32:49 +0300 Message-ID: <35470587.gVktJpfmq0@avalon> References: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com> <20180427165722.19445-12-kieran.bingham+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180427165722.19445-12-kieran.bingham+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Simon Horman , Catalin Marinas , Magnus Damm , open list , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Rob Herring , Will Deacon , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" List-Id: devicetree@vger.kernel.org SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXksIDI3IEFwcmls IDIwMTggMTk6NTc6MjIgRUVTVCBLaWVyYW4gQmluZ2hhbSB3cm90ZToKPiBUaGUgRFUxIGV4dGVy bmFsIGRvdCBjbG9jayBpcyBwcm92aWRlZCBieSB0aGUgZml4ZWQgZnJlcXVlbmN5IGNsb2NrCj4g Z2VuZXJhdG9yIFgyMSwgd2hpbGUgdGhlIERVMCBhbmQgRFUzIGNsb2NrcyBhcmUgcHJvdmlkZWQg YnkgdGhlCj4gcHJvZ3JhbW1hYmxlIFZlcnNhY2xvY2s2IGNsb2NrIGdlbmVyYXRvci4KPiAKPiBF bmFibGUgdGhlIGNsb2NrcywgYW5kIHRoZSBIRE1JIGVuY29kZXIgZm9yIHRoZSBNMy1OIFNhbHZh dG9yLVhTLCBhbmQKPiBob29rIGl0IHVwIHRvIHRoZSBIRE1JIGNvbm5lY3Rvcgo+IAo+IEJhc2Vk IG9uIHBhdGNoZXMgZnJvbSBUYWtlc2hpIEtpaGFyYSA8dGFrZXNoaS5raWhhcmEuZGZAcmVuZXNh cy5jb20+Cj4gCj4gU2lnbmVkLW9mZi1ieTogS2llcmFuIEJpbmdoYW0gPGtpZXJhbi5iaW5naGFt K3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiAtLS0KPiAgLi4uL2Jvb3QvZHRzL3JlbmVzYXMv cjhhNzc5NjUtc2FsdmF0b3IteHMuZHRzIHwgMjkgKysrKysrKysrKysrKysrKysrKwo+ICAxIGZp bGUgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0 L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5NjUtc2FsdmF0b3IteHMuZHRzCj4gYi9hcmNoL2FybTY0 L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5NjUtc2FsdmF0b3IteHMuZHRzIGluZGV4Cj4gYTgzYTAw ZGVlZDllLi5kY2YxODQ5ZjFhNjcgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9y ZW5lc2FzL3I4YTc3OTY1LXNhbHZhdG9yLXhzLmR0cwo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9k dHMvcmVuZXNhcy9yOGE3Nzk2NS1zYWx2YXRvci14cy5kdHMKPiBAQCAtMTksMyArMTksMzIgQEAK PiAgCQlyZWcgPSA8MHgwIDB4NDgwMDAwMDAgMHgwIDB4NzgwMDAwMDA+Owo+ICAJfTsKPiAgfTsK PiArCj4gKyZkdSB7Cj4gKwljbG9ja3MgPSA8JmNwZyBDUEdfTU9EIDcyND4sCj4gKwkJIDwmY3Bn IENQR19NT0QgNzIzPiwKPiArCQkgPCZjcGcgQ1BHX01PRCA3MjE+LAo+ICsJCSA8JmNwZyBDUEdf TU9EIDcyNz4sCj4gKwkJIDwmdmVyc2FjbG9jazYgMT4sCj4gKwkJIDwmeDIxX2Nsaz4sCj4gKwkJ IDwmdmVyc2FjbG9jazYgMj47Cj4gKwljbG9jay1uYW1lcyA9ICJkdS4wIiwgImR1LjEiLCAiZHUu MyIsICJsdmRzLjAiLAo+ICsJCSAgICAgICJkY2xraW4uMCIsICJkY2xraW4uMSIsICJkY2xraW4u MyI7CgpZb3Ugc2hvdWxkIHJlbW92ZSB0aGUgTFZEUyBjbG9jayBmcm9tIGhlcmUgdG9vLgoKQXBh cnQgZnJvbSB0aGF0LAoKUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGlu Y2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gK307Cj4gKwo+ICsmaGRtaTAgewo+ICsJc3RhdHVz ID0gIm9rYXkiOwo+ICsKPiArCXBvcnRzIHsKPiArCQlwb3J0QDEgewo+ICsJCQlyZWcgPSA8MT47 Cj4gKwkJCXJjYXJfZHdfaGRtaTBfb3V0OiBlbmRwb2ludCB7Cj4gKwkJCQlyZW1vdGUtZW5kcG9p bnQgPSA8JmhkbWkwX2Nvbj47Cj4gKwkJCX07Cj4gKwkJfTsKPiArCX07Cj4gK307Cj4gKwo+ICsm aGRtaTBfY29uIHsKPiArCXJlbW90ZS1lbmRwb2ludCA9IDwmcmNhcl9kd19oZG1pMF9vdXQ+Owo+ ICt9OwoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=