From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38B7EC433EF for ; Wed, 27 Oct 2021 22:29:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15068610CB for ; Wed, 27 Oct 2021 22:29:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbhJ0WbZ (ORCPT ); Wed, 27 Oct 2021 18:31:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbhJ0WbY (ORCPT ); Wed, 27 Oct 2021 18:31:24 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 201EAC061570; Wed, 27 Oct 2021 15:28:59 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id in13so817026pjb.1; Wed, 27 Oct 2021 15:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ts7jQwvxo7Esv/bJT5YrOOKnlyDGF2TkgNS9/cVB0Xw=; b=PDpS1Uz8xBPiXrmKnw6VN4A+Jlasl/WUpaZ9r8ZkkrI90ZdrHhX/peCmwjt0lT5UeL goz5ILtNrroZdOgrLmTt0vrCCFRejt/gsH6inFvfk4qS9MFOPfJgocfdoe++1c6n4d9k FZ9zVr9MvDkNTRUjr6YdxNne29A/62HTEUol36dWq6vRBVjUYICwZEVoDhB4nHZbzJmA VjITdAbSvCEfX1A1nvcSjSpDbT0YhOcYBRJkhEnvgPPyBEoEDs2Uy/IOObn/OziA84Un vg9n0b6eW27q+tNwD2vJmCctz9vmSMQH2Ckg1lPzSArJBcSJSznIgMd0Ca6mBjx8F8Fd aJxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ts7jQwvxo7Esv/bJT5YrOOKnlyDGF2TkgNS9/cVB0Xw=; b=x0bW1Tybo73t4G9RXHip97UZRHNXwm4ur+h2a4JpWFKuQl95mXuIKSdvSugk1wPqjs TIDiOLOiuYcx8mKyDg3qURRrgEVrHz/LJd7Z25Z9qTrKJbWnu0Fn68WF1LMs+WntWKW3 LjL7O9yLtji3qNXHhqAy3sqhpL68pnPC556kMvts3peZhe4k5FnXy4O364W4UoTUhPRJ cTsGjAOYuT1HI1I13/J53JS4DV/yAj5hcE7EV4X3sxhV+EkNGcOzMZZj5uOiZg3t0/sy 32j1mhedFIm8h1RYXeBH78QHVDUMikpN5iq4tdmm4LFIb/wGuyZDkbHIskE8p5VvdKOc b57w== X-Gm-Message-State: AOAM531pJkys6exrURWRwmxzVICTNoiedSKq+9Ru6SUmXZ6XJK8rWWmD r30EG8czVOJ/o3yHFCqCunE= X-Google-Smtp-Source: ABdhPJz3640rQYhKT4HCqWVeTovoH/x9LWBvXnkN2DOg+41qBmG0k2k5nBtT42TMCd3Zbt+ATQS+mA== X-Received: by 2002:a17:902:c215:b0:141:690a:863a with SMTP id 21-20020a170902c21500b00141690a863amr313595pll.22.1635373738647; Wed, 27 Oct 2021 15:28:58 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id i5sm718446pgo.36.2021.10.27.15.28.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 15:28:58 -0700 (PDT) Subject: Re: [PATCH 3/3] watchdog: bcm63xx_wdt: support BCM4908 To: Guenter Roeck , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Wim Van Sebroeck , Rob Herring , Thomas Bogendoerfer , bcm-kernel-feedback-list@broadcom.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20211027215531.9996-1-zajec5@gmail.com> <20211027215531.9996-3-zajec5@gmail.com> <20211027222213.GB342815@roeck-us.net> From: Florian Fainelli Message-ID: <35519aa4-266e-04f4-baed-fa41f2b2d989@gmail.com> Date: Wed, 27 Oct 2021 15:28:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211027222213.GB342815@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 10/27/21 3:22 PM, Guenter Roeck wrote: > On Wed, Oct 27, 2021 at 11:55:31PM +0200, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> So far bcm63xx_wdt included support for Broadcom's watchdog block of old >> MIPS devices only. It was also a fully platform (non-DT) driver. >> >> The same block was recently found on BCM4908 with just a slightly >> different registers layout. Extend this driver to support OF and add >> support for per-chipset registers offsets. >> >> Signed-off-by: Rafał Miłecki > > Please convert the driver to use the watchdog subsystem first. > Also, when doing so, please explain why you don't use the bcm7038 > driver instead, since it serves the same hardware interface and > already supports the watchdog core. This is too ugly unfortunately so yes let us use bcm7038_wdt.c and let me know if you need help with converting arch/mips/bcm63xx to use the bcm7038_wdt.c -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C65CEC433F5 for ; Wed, 27 Oct 2021 22:30:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8133B6023E for ; Wed, 27 Oct 2021 22:30:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8133B6023E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=AVpS8gU5aMdGi9CviW8Gk7vjQ45qGKmjsX14EGTWo0s=; b=ULzDf/Eorj2D9EER37/j3MyLGL JLeTN2cA30z//viwVG0HU6YFt4R6VxwIFE4bMLuX1Z2kOi7Fmo5ms5TFjZKsXQRXCzKs3o6QbHT61 J+JvF/c2qkbbpPalgE4Tgu7qwndmOwuSTr3xKRlDl6jdyQVdcSJOpUpaVh1VOiHNcuXmWOVHLDMWu /TzeD4s8O8QWFo6ukt9R6RWRPa1RWBFTTnxjSJIi47UKcIqQfQ25p6+wgJQ/gH8/NMw//Bh53uIrQ k+iTH3KiJSD1RcYdfwVh0HlMBBW3X/j+MLxUWxurgEflHn281z5OKfpyYEKvFV73s53jdBAYGsLdM Z0e7k3XA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfrPs-006PEd-Iz; Wed, 27 Oct 2021 22:29:04 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfrPo-006PE4-Qd for linux-arm-kernel@lists.infradead.org; Wed, 27 Oct 2021 22:29:02 +0000 Received: by mail-pj1-x102f.google.com with SMTP id gn3so3216376pjb.0 for ; Wed, 27 Oct 2021 15:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ts7jQwvxo7Esv/bJT5YrOOKnlyDGF2TkgNS9/cVB0Xw=; b=PDpS1Uz8xBPiXrmKnw6VN4A+Jlasl/WUpaZ9r8ZkkrI90ZdrHhX/peCmwjt0lT5UeL goz5ILtNrroZdOgrLmTt0vrCCFRejt/gsH6inFvfk4qS9MFOPfJgocfdoe++1c6n4d9k FZ9zVr9MvDkNTRUjr6YdxNne29A/62HTEUol36dWq6vRBVjUYICwZEVoDhB4nHZbzJmA VjITdAbSvCEfX1A1nvcSjSpDbT0YhOcYBRJkhEnvgPPyBEoEDs2Uy/IOObn/OziA84Un vg9n0b6eW27q+tNwD2vJmCctz9vmSMQH2Ckg1lPzSArJBcSJSznIgMd0Ca6mBjx8F8Fd aJxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ts7jQwvxo7Esv/bJT5YrOOKnlyDGF2TkgNS9/cVB0Xw=; b=EbMCxEXq3FlzaKUgBrZmDGPvcTlpDrg9GaCUd1Xv5lLaLUlcBoCPt+rDAwZjUzCR09 ee1MbnFbGlHSZFLCtr8JU0n/RfMqGVOeP7NJFO8R4aW9wktVshooLB0pRZVm9UWj9lGG z0IdaPF9vPSiE1NbFxcB1lN29iKV3DX1wKU0fUhx2WfuYsvESMcn89jHGEtyxl7SC/+e vsx2nAkhGUMHrGo+pGx7OyDzEhOT7nY0PtnrR75MmMRO4PPPisHu+hIfhT6JjCKx7JLj P0g9stFkKe00rskIux5AU161qVYJw5cw24pPsOaGoNi2lixzRQ948imVEzrmBD6m0rTB e/tg== X-Gm-Message-State: AOAM533QHkt/Y/4ZWAatXDvZHQHnWGJd4CcuCNQa5cRP8GdsSuKeTdEu U0X70bSQQ391LdS7iquy9IU= X-Google-Smtp-Source: ABdhPJz3640rQYhKT4HCqWVeTovoH/x9LWBvXnkN2DOg+41qBmG0k2k5nBtT42TMCd3Zbt+ATQS+mA== X-Received: by 2002:a17:902:c215:b0:141:690a:863a with SMTP id 21-20020a170902c21500b00141690a863amr313595pll.22.1635373738647; Wed, 27 Oct 2021 15:28:58 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id i5sm718446pgo.36.2021.10.27.15.28.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 15:28:58 -0700 (PDT) Subject: Re: [PATCH 3/3] watchdog: bcm63xx_wdt: support BCM4908 To: Guenter Roeck , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Wim Van Sebroeck , Rob Herring , Thomas Bogendoerfer , bcm-kernel-feedback-list@broadcom.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20211027215531.9996-1-zajec5@gmail.com> <20211027215531.9996-3-zajec5@gmail.com> <20211027222213.GB342815@roeck-us.net> From: Florian Fainelli Message-ID: <35519aa4-266e-04f4-baed-fa41f2b2d989@gmail.com> Date: Wed, 27 Oct 2021 15:28:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211027222213.GB342815@roeck-us.net> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_152900_886501_020E0F4C X-CRM114-Status: GOOD ( 16.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTAvMjcvMjEgMzoyMiBQTSwgR3VlbnRlciBSb2VjayB3cm90ZToKPiBPbiBXZWQsIE9jdCAy NywgMjAyMSBhdCAxMTo1NTozMVBNICswMjAwLCBSYWZhxYIgTWnFgmVja2kgd3JvdGU6Cj4+IEZy b206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPj4KPj4gU28gZmFyIGJjbTYz eHhfd2R0IGluY2x1ZGVkIHN1cHBvcnQgZm9yIEJyb2FkY29tJ3Mgd2F0Y2hkb2cgYmxvY2sgb2Yg b2xkCj4+IE1JUFMgZGV2aWNlcyBvbmx5LiBJdCB3YXMgYWxzbyBhIGZ1bGx5IHBsYXRmb3JtIChu b24tRFQpIGRyaXZlci4KPj4KPj4gVGhlIHNhbWUgYmxvY2sgd2FzIHJlY2VudGx5IGZvdW5kIG9u IEJDTTQ5MDggd2l0aCBqdXN0IGEgc2xpZ2h0bHkKPj4gZGlmZmVyZW50IHJlZ2lzdGVycyBsYXlv dXQuIEV4dGVuZCB0aGlzIGRyaXZlciB0byBzdXBwb3J0IE9GIGFuZCBhZGQKPj4gc3VwcG9ydCBm b3IgcGVyLWNoaXBzZXQgcmVnaXN0ZXJzIG9mZnNldHMuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFJh ZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPiAKPiBQbGVhc2UgY29udmVydCB0aGUg ZHJpdmVyIHRvIHVzZSB0aGUgd2F0Y2hkb2cgc3Vic3lzdGVtIGZpcnN0Lgo+IEFsc28sIHdoZW4g ZG9pbmcgc28sIHBsZWFzZSBleHBsYWluIHdoeSB5b3UgZG9uJ3QgdXNlIHRoZSBiY203MDM4Cj4g ZHJpdmVyIGluc3RlYWQsIHNpbmNlIGl0IHNlcnZlcyB0aGUgc2FtZSBoYXJkd2FyZSBpbnRlcmZh Y2UgYW5kCj4gYWxyZWFkeSBzdXBwb3J0cyB0aGUgd2F0Y2hkb2cgY29yZS4KClRoaXMgaXMgdG9v IHVnbHkgdW5mb3J0dW5hdGVseSBzbyB5ZXMgbGV0IHVzIHVzZSBiY203MDM4X3dkdC5jIGFuZCBs ZXQKbWUga25vdyBpZiB5b3UgbmVlZCBoZWxwIHdpdGggY29udmVydGluZyBhcmNoL21pcHMvYmNt NjN4eCB0byB1c2UgdGhlCmJjbTcwMzhfd2R0LmMKLS0gCkZsb3JpYW4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK