From: Paolo Abeni <pabeni@redhat.com>
To: "Linus Walleij" <linusw@kernel.org>,
"Hans Ulli Kroll" <ulli.kroll@googlemail.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org, Joe Damato <joe@dama.to>
Subject: Re: [PATCH v2 0/5] net: ethernet: cortina: Fix RX budget accounting
Date: Tue, 8 Sep 2026 12:33:14 +0200 [thread overview]
Message-ID: <355421f8-63ec-43a4-8982-01312f79dc6c@redhat.com> (raw)
In-Reply-To: <20260903-gemini-ethernet-fixes-v2-0-2bbbd598ca6e@kernel.org>
On 9/3/26 11:45 PM, Linus Walleij wrote:
> Finish RX updates before releasing NAPI ownership, report actual NAPI
> work, charge dropped frames to the poll budget, and drive free-queue
> refills from consumed RX descriptors.
>
> Track RX drop state across descriptor chains so discarded frames are
> counted exactly once.
>
> Tested on the D-Link DIR-685.
>
> Hi Sashiko, yes there are more latent issues I will get to them, but
> my LLM thinks those are on the top of the list.
>
> Assisted-by: LLM
> Signed-off-by: Linus Walleij <linusw@kernel.org>
Sashiko has a couple of comments, but the first one is a giant "this is
solved by the next patch" and I read the 2nd alike "if H/W is broken s/w
accounting could be inaccurate" which in turn is not a big deal.
@Linus, note that the current expectation is for the patch submitter to
provide something alike the above feedback.
/P
next prev parent reply other threads:[~2026-09-08 10:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 21:45 [PATCH v2 0/5] net: ethernet: cortina: Fix RX budget accounting Linus Walleij
2026-09-03 21:45 ` [PATCH v2 1/5] net: ethernet: cortina: Fix " Linus Walleij
2026-09-07 4:19 ` netdev-bot+sashiko
2026-09-03 21:45 ` [PATCH v2 2/5] net: ethernet: cortina: Finish RX updates before NAPI completion Linus Walleij
2026-09-03 21:45 ` [PATCH v2 3/5] net: ethernet: cortina: Count dropped frames as NAPI work Linus Walleij
2026-09-07 4:19 ` netdev-bot+sashiko
2026-09-03 21:45 ` [PATCH v2 4/5] net: ethernet: cortina: Count RX drops once per frame Linus Walleij
2026-09-03 21:45 ` [PATCH v2 5/5] net: ethernet: cortina: Count RX descriptors for freeq refill Linus Walleij
2026-09-08 10:33 ` Paolo Abeni [this message]
2026-09-08 17:46 ` [PATCH v2 0/5] net: ethernet: cortina: Fix RX budget accounting Linus Walleij
2026-09-08 10:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=355421f8-63ec-43a4-8982-01312f79dc6c@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joe@dama.to \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.