All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Wiles,
	Roger Keith"
	<keith.wiles-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: 1.7.0 release failed to compile on linux
Date: Sat, 16 Aug 2014 00:41:38 +0200	[thread overview]
Message-ID: <3556499.hMzHJM9L0j@xps13> (raw)
In-Reply-To: <4B613BEE-2D07-417D-ACA3-6C228FADB14E-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>

Hi Keith,

2014-08-14 21:55, Wiles, Roger Keith:
> /* #### Changed the next line to use (3,13,8) instead of (3,14,0) KeithW */
> #if ( LINUX_VERSION_CODE < KERNEL_VERSION(3,13,8) )
> #if (!(RHEL_RELEASE_CODE && RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,0)))
> #ifdef NETIF_F_RXHASH
> #define PKT_HASH_TYPE_L3 0
> static inline void
> skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
> {
>     skb->rxhash = hash;
> }
> #endif /* NETIF_F_RXHASH */
> #endif /* < RHEL7 */
> #endif /* < 3.14.0 */

I really don't understand why changing condition from
	< 3.14.0
to
	< 3.13.8
would be better?
This function appeared in 3.14.0. Maybe that Ubuntu backported it for their
12.04 version, so it must be handled with a specific Ubuntu check as it was
already done for Ubuntu 14.04:
	#if (!(UBUNTU_RELEASE_CODE == UBUNTU_RELEASE_VERSION(14,4) &&
	UBUNTU_KERNEL_CODE >= UBUNTU_KERNEL_VERSION(3,13,0,30,54)))

Please help to improve what is done in master branch by providing patches.

Note: please do not top post and try to use cite mark '>'

Thanks
-- 
Thomas

  parent reply	other threads:[~2014-08-15 22:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 21:44 1.7.0 release failed to compile on linux Qiaobing Xie
     [not found] ` <53ED2DBF.4070003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-14 21:55   ` Wiles, Roger Keith
     [not found]     ` <4B613BEE-2D07-417D-ACA3-6C228FADB14E-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2014-08-14 22:24       ` Aws Ismail
     [not found]         ` <53ED3710.3090008-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2014-08-14 22:57           ` Qiaobing Xie
2014-08-14 23:27           ` Qiaobing Xie
2014-08-15 22:41       ` Thomas Monjalon [this message]
2014-08-17  0:10         ` [please ignore this test email] Wiles, Roger Keith
2014-08-14 22:15   ` 1.7.0 release failed to compile on linux Aws Ismail
     [not found]     ` <53ED34FC.3050405-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2014-08-15  0:16       ` Neil Horman
     [not found]         ` <20140815001651.GA11038-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2014-08-15  0:31           ` Qiaobing Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3556499.hMzHJM9L0j@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=keith.wiles-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.