All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Coccinelle: understanding its output
Date: Mon, 19 Apr 2021 19:45:20 +0200	[thread overview]
Message-ID: <3557115.gcaS8tdjop@linux.local> (raw)

I think that I don't yet understand Coccinelle's output. 

I've just run the following command:
spatch --sp-file scripts/coccinelle/free/kfree.cocci --dir drivers/staging/
wlan-ng/prism2fw.c

It outputs something that looks like a patch:

HANDLING: drivers/staging/wlan-ng/prism2fw.c
     (ONCE) already tagged but only removed, so safe
diff = 
--- drivers/staging/wlan-ng/prism2fw.c
+++ /tmp/cocci-output-17844-0c6c7c-prism2fw.c

First, what is /tmp/cocci-output-17844-0c6c7c-prism2fwc? It is not a file in /
tmp. If it is a file, where is it?

The output goes on with lines like the following ones:

  @@ -1008,8 +1005,6 @@ static int writeimage(struct wlandevice
        rstmsg = kzalloc(sizeof(*rstmsg), GFP_KERNEL);
        rwrmsg = kzalloc(sizeof(*rwrmsg), GFP_KERNEL);
        if (!rstmsg || !rwrmsg) {
-               kfree(rstmsg);
-               kfree(rwrmsg);
                netdev_err(wlandev->netdev,
                           "%s: no memory for firmware download, aborting 
download\n",
                           __func__);

Please read the two lines with a trailing '-'... Does Coccinelle mean that 
they should be removed? If yes, I'm not able to understand why, because I 
think they must not be removed. Am I wrong?

 I'd appreciate some help.

Thanks,

Fabio
 




             reply	other threads:[~2021-04-19 17:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19 17:45 Fabio M. De Francesco [this message]
2021-04-19 18:58 ` [Outreachy kernel] Coccinelle: understanding its output Julia Lawall
2021-04-20 15:59   ` Fabio M. De Francesco
2021-04-20 16:37     ` Julia Lawall
2021-04-20 17:03       ` Fabio M. De Francesco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3557115.gcaS8tdjop@linux.local \
    --to=fmdefrancesco@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.