From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Artur Weber <aweber.kernel@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Scott Branden <sbranden@broadcom.com>,
Markus Mayer <markus.mayer@linaro.org>,
Tim Kryger <tim.kryger@linaro.org>,
Matt Porter <matt.porter@linaro.org>,
Markus Mayer <mmayer@broadcom.com>,
Christian Daudt <csd@broadcom.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/3] gpio: bcm-kona: Make sure GPIO bits are unlocked when requesting IRQ
Date: Thu, 30 Jan 2025 14:13:02 -0800 [thread overview]
Message-ID: <356d5a78-85ee-45ef-90a4-b88dc1a3448c@broadcom.com> (raw)
In-Reply-To: <20250130-kona-gpio-fixes-v1-2-dd61e0c0a9e7@gmail.com>
On 1/30/25 09:10, Artur Weber wrote:
> The settings for all GPIOs are locked by default in bcm_kona_gpio_reset.
> The settings for a GPIO are unlocked when requesting it as a GPIO, but
> not when requesting it as an interrupt, causing the IRQ settings to not
> get applied.
>
> Fix this by making sure to unlock the right bits when an IRQ is requested.
> To avoid a situation where an IRQ being released causes a lock despite
> the same GPIO being used by a GPIO request or vice versa, add an unlock
> counter and only lock if it reaches 0.
>
> Fixes: 757651e3d60e ("gpio: bcm281xx: Add GPIO driver")
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2025-01-30 22:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 17:10 [PATCH 0/3] gpio: bcm-kona: Various GPIO fixups Artur Weber
2025-01-30 17:10 ` [PATCH 1/3] gpio: bcm-kona: Fix GPIO lock/unlock for banks above bank 0 Artur Weber
2025-01-30 21:33 ` Florian Fainelli
2025-01-30 22:00 ` Markus Mayer
2025-01-30 17:10 ` [PATCH 2/3] gpio: bcm-kona: Make sure GPIO bits are unlocked when requesting IRQ Artur Weber
2025-01-30 21:35 ` Florian Fainelli
2025-01-30 21:46 ` Artur Weber
2025-01-30 22:07 ` Florian Fainelli
2025-01-30 22:13 ` Florian Fainelli [this message]
2025-01-30 22:36 ` Markus Mayer
2025-01-30 17:10 ` [PATCH 3/3] gpio: bcm-kona: Add missing newline to dev_err format string Artur Weber
2025-01-30 18:41 ` Florian Fainelli
2025-01-30 22:08 ` Markus Mayer
2025-02-06 9:34 ` [PATCH 0/3] gpio: bcm-kona: Various GPIO fixups Linus Walleij
2025-02-06 9:36 ` Linus Walleij
2025-02-06 15:37 ` Artur Weber
2025-02-06 17:48 ` Artur Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=356d5a78-85ee-45ef-90a4-b88dc1a3448c@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=csd@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=matt.porter@linaro.org \
--cc=mmayer@broadcom.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=tim.kryger@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.