All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4] syscalls/membarrier: Add membarrier() initial test
Date: Mon, 8 Oct 2018 10:25:19 -0400 (EDT)	[thread overview]
Message-ID: <357830099.56894195.1539008719156.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <75dc7e79-ddc2-f5ee-4fb5-dfcb7385e4df@linaro.org>



----- Original Message -----
> On 10/8/18 11:07 AM, Jan Stancek wrote:
> > 
> > 
> > ----- Original Message -----
> >> Fixes: #265
> >>
> >> Initial test for membarrier() syscall. It tests all existing membarrier
> >> "commands" (or features), including the need (or not) for previous
> >> registration for the call to work.
> >>
> >> Some features did not exist in older kernels and that is covered by
> >> skipping some calls, flagging test as skipped & okay, and forcing
> >> others, making sure that return codes and errno are set right in those
> >> cases.
> >>
> >> Tests are done in a child process due to inexistent kernel interface to
> >> "unregister" the process from being affected by membarrier() call.
> >>
> >> Signed-off-by: Rafael David Tinoco <rafael.tinoco@linaro.org>
> > 
> > Looks good to me.
> > 
> > We probably can drop linux/membarrier.h configure check, right?
> > (since v4 doesn't include it and unsupported kernel should
> > hit ENOSYS and TCONF)
> 
> Ooops, true. No need to check HAVE_LINUX_MEMBARRIER_H if we are
> declaring all CMDs and will be given ENOSYS. Want me to send a v5 ?

Let's give a couple days to other potential reviewers. If nothing
else comes up, I can drop it before push.

Thanks,
Jan

  reply	other threads:[~2018-10-08 14:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27 22:09 [LTP] [PATCH] syscalls/membarrier: Add membarrier() initial test Rafael David Tinoco
2018-09-27 22:12 ` Rafael David Tinoco
2018-10-01  8:47 ` Jan Stancek
2018-10-05 20:39   ` [LTP] [PATCH v2] " Rafael David Tinoco
2018-10-05 20:46     ` Rafael David Tinoco
2018-10-08  0:08   ` [LTP] [PATCH v3] " Rafael David Tinoco
2018-10-08  0:11     ` Rafael David Tinoco
2018-10-08  6:41     ` Jan Stancek
2018-10-08 13:29   ` [LTP] [PATCH v4] " Rafael David Tinoco
2018-10-08 14:07     ` Jan Stancek
2018-10-08 14:13       ` Rafael David Tinoco
2018-10-08 14:25         ` Jan Stancek [this message]
2018-10-08 14:43           ` Rafael David Tinoco
2018-10-11  9:06             ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=357830099.56894195.1539008719156.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.