From: Thomas Monjalon <thomas@monjalon.net>
To: "Abdullah Ömer Yamaç" <omer.yamac@ceng.metu.edu.tr>
Cc: Ferruh Yigit <ferruh.yigit@xilinx.com>,
stable@dpdk.org, dev@dpdk.org,
David Marchand <david.marchand@redhat.com>,
"Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH] examples/distributor: fix syntax on single core rx and distributor
Date: Sun, 26 Jun 2022 23:30:06 +0200 [thread overview]
Message-ID: <3588515.MzOyzyC30C@thomas> (raw)
In-Reply-To: <d165836f-02c5-03de-f656-5d105e47853b@intel.com>
21/06/2022 10:44, Hunt, David:
> On 20/06/2022 18:10, Ferruh Yigit wrote:
> > On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
> >> This patch fixes the syntax error when using the single-core
> >> for both rx and distributor functions.
> >>
> >> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
> >
> > Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
> >
> > Can we convert compile time macro to dynamic configuration to prevent
> > build errors like this?
>
> +1 for the dynamic config. Maybe a "-c" on the command line for "combine
> rx and dist threads"?
>
> Tested-by: David Hunt <david.hunt@intel.com>
Applied this fix, thanks.
Improvement with dynamic option can come later.
prev parent reply other threads:[~2022-06-26 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 16:31 [PATCH] examples/distributor: fix syntax on single core rx and distributor Abdullah Ömer Yamaç
2022-06-20 17:10 ` Ferruh Yigit
2022-06-21 8:44 ` Hunt, David
2022-06-21 10:26 ` Ferruh Yigit
2022-06-21 11:18 ` Omer Yamac
2022-06-21 11:24 ` Ferruh Yigit
2022-06-26 21:30 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3588515.MzOyzyC30C@thomas \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=omer.yamac@ceng.metu.edu.tr \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.