From: Markus Elfring <Markus.Elfring@web.de>
To: Ioana Ciornei <ioana.ciornei@nxp.com>,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org
Cc: Christophe Leroy <chleroy@kernel.org>,
Dan Carpenter <error27@gmail.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Peter Zijlstra <peterz@infradead.org>,
Roy Pledge <Roy.Pledge@nxp.com>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [v2 1/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_store_create()
Date: Tue, 28 Jul 2026 08:55:38 +0200 [thread overview]
Message-ID: <3588f06e-7d11-4e94-b141-008e676bb28b@web.de> (raw)
In-Reply-To: <55dkpjlibtfurmrrzxzznq6e3dhxvo76rsrjnokkaquwktl74r@omft73n4kp52>
>> https://elixir.bootlin.com/linux/v7.2-rc4/source/include/linux/cleanup.h#L142-L146
>
> The context for the recommendation linked by you is (also from
> cleanup.h):
>
> * "When multiple variables in the same scope have cleanup attributes,
> * at exit from the scope their associated cleanup functions are run in
> * reverse order of definition (last defined, first cleanup)."
> *
> * When the unwind order matters it requires that variables be defined
> * mid-function scope rather than at the top of the file. Take the
> * following example and notice the bug highlighted by "!!"::
>
> Which is not the case of these simple functions which only need a kfree.
How will development concerns evolve further also according to previous clarification attempts?
Clarifying confusion of our variable placement rules caused by cleanup.h
https://lore.kernel.org/ksummit/CAHk-=whPZoi03ZwphxiW6cuWPtC3nyKYS8_BThgztCdgPWP1WA@mail.gmail.com/
https://lkml.org/lkml/2025/11/18/1766
Regards,
Markus
next prev parent reply other threads:[~2026-07-28 6:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 10:02 [PATCH] soc: fsl: dpio: Use common error handling code in two functions Markus Elfring
2026-07-04 9:19 ` Christophe Leroy (CS GROUP)
2026-07-04 10:11 ` Markus Elfring
2026-07-06 10:36 ` [PATCH v2 0/2] soc: fsl: dpio: Use scope-based resource management " Markus Elfring
2026-07-06 10:38 ` [PATCH v2 1/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_store_create() Markus Elfring
2026-07-27 11:31 ` Dan Carpenter
2026-07-29 8:24 ` Markus Elfring
2026-07-27 12:08 ` Ioana Ciornei
2026-07-27 12:24 ` [v2 " Markus Elfring
2026-07-27 12:46 ` Ioana Ciornei
2026-07-27 12:52 ` Markus Elfring
2026-07-28 6:55 ` Markus Elfring [this message]
2026-07-28 10:40 ` Ioana Ciornei
2026-07-28 11:15 ` Markus Elfring
2026-07-06 10:40 ` [PATCH v2 2/2] soc: fsl: dpio: Use scope-based resource management in dpaa2_io_create() Markus Elfring
2026-07-27 11:32 ` Dan Carpenter
2026-07-27 12:14 ` [v2 " Markus Elfring
2026-07-27 12:09 ` [PATCH v2 " Ioana Ciornei
2026-07-27 13:14 ` [v2 " Markus Elfring
2026-07-27 9:57 ` [PATCH v2 0/2] soc: fsl: dpio: Use scope-based resource management in two functions Christophe Leroy (CS GROUP)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3588f06e-7d11-4e94-b141-008e676bb28b@web.de \
--to=markus.elfring@web.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Roy.Pledge@nxp.com \
--cc=chleroy@kernel.org \
--cc=error27@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.