From: Thomas Monjalon <thomas@monjalon.net>
To: Harman Kalra <hkalra@marvell.com>
Cc: dev@dpdk.org, "remy.horton@intel.com" <remy.horton@intel.com>,
"jerin.jacobkollanukkaran@cavium.com"
<jerin.jacobkollanukkaran@cavium.com>
Subject: Re: [PATCH v2] test/metrics: Fixed a negative case to pass
Date: Sun, 20 Jan 2019 22:31:52 +0100 [thread overview]
Message-ID: <3592747.moUssd9yEs@xps> (raw)
In-Reply-To: <20181210083857.3158-1-hkalra@marvell.com>
10/12/2018 09:39, Harman Kalra:
> Negative test case for passing invalid count size to
> rte_metrics_update_values() will pass if count value
> is any value greater than 1 because set size wrt to
> key id 1 is 1 and passing 0 as no of values to be
> updated will not hit the ERANGE check.
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
Adding comment from Remy:
Fixes: cd3804242901 ("test/metrics: add unit tests for metrics library")
Acked-by: Remy Horton <remy.horton@intel.com>
Applied, thanks
prev parent reply other threads:[~2019-01-20 21:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 15:01 [PATCH] test/metrics: Fixed a negative case to pass Harman Kalra
2018-12-07 11:45 ` Remy Horton
2018-12-10 8:44 ` [PATCH v2] " Harman Kalra
2018-12-10 8:39 ` Harman Kalra
2019-01-20 21:31 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3592747.moUssd9yEs@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=jerin.jacobkollanukkaran@cavium.com \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.