From: Thomas Monjalon <thomas@monjalon.net>
To: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
David Marchand <david.marchand@redhat.com>,
Jerin Jacob <jerinjacobk@gmail.com>
Cc: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter
Date: Fri, 30 Jul 2021 12:31:35 +0200 [thread overview]
Message-ID: <3595021.RRgZMKagN0@thomas> (raw)
In-Reply-To: <CALBAE1P+43x6nCszRMFzUD9F4ETv_D6wmTBxDBs63O9OkpnTtw@mail.gmail.com>
30/07/2021 12:24, Jerin Jacob:
> On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
> <jay.jayatheerthan@intel.com> wrote:
> >
> > > -----Original Message-----
> > > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > Sent: Wednesday, July 28, 2021 3:01 PM
> > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
>
> > >
> > > >
> > > > >
> > > > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > >
> > >
> > > @Naga Harish K, S V Can we remove "," from the Signoff name.
> > >
> > > Some suggestions for consideration in preferred order. Let me know
> > > your preferred Signoff name, I will change it accordingly.
> > >
> > > Naga Harish <s.v.naga.harish.k@intel.com>
> > >
> > > or
> > >
> > > Naga Harish K <s.v.naga.harish.k@intel.com>
> > >
> > > or
> > >
> > > Naga Harish K S V <s.v.naga.harish.k@intel.com>
> >
> > This option is good. (Harish is out and hence I am responding)
>
> 1) Option 'Signed-off-by: Naga Harish K S V
> <s.v.naga.harish.k@intel.com> is warned by checkpatch
>
> [for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1
>
> ### eventdev: fix event port setup in Tx adapter
>
> WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name
> mismatch: 'From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>'
> != 'Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>'
>
> 2) Option 'Signed-off-by: Naga Harish K, S V
> <s.v.naga.harish.k@intel.com>' is warning by check-git-log.sh
>
> [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
> Wrong tag:
> Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
>
>
> @thomas @David Marchand
>
> Could you suggest what Sign-off to take?
The first option is probably OK but the problem is a mismatch with the author name.
Make sure to change the authorship with --amend --author=
next prev parent reply other threads:[~2021-07-30 10:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 8:12 [dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter Naga Harish K, S V
2021-07-23 11:27 ` Jayatheerthan, Jay
2021-07-23 11:36 ` Jerin Jacob
2021-07-24 14:10 ` [dpdk-dev] [PATCH v2] eventdev: fix event port setup " Naga Harish K, S V
2021-07-28 6:44 ` Jayatheerthan, Jay
2021-07-28 9:30 ` Jerin Jacob
2021-07-28 10:57 ` Jayatheerthan, Jay
2021-07-30 10:24 ` Jerin Jacob
2021-07-30 10:31 ` Thomas Monjalon [this message]
2021-07-30 10:36 ` Jerin Jacob
2021-07-30 10:59 ` Jerin Jacob
-- strict thread matches above, loose matches on Subject: below --
2021-07-24 13:54 Naga Harish K, S V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3595021.RRgZMKagN0@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=s.v.naga.harish.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.