From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
stable@dpdk.org
Subject: Re: [PATCH] telemetry: fix error when using ports of different types
Date: Fri, 21 Dec 2018 00:51:26 +0100 [thread overview]
Message-ID: <35952782.MrcKBpYm8b@xps> (raw)
In-Reply-To: <20181219115950.46386-1-bruce.richardson@intel.com>
19/12/2018 12:59, Bruce Richardson:
> Different NIC ports can have different numbers of xstats on them, which
> means that we can't just use the xstats list from the first port registered
> in the telemetry library. Instead, we need to check the type of each port -
> by checking its ops structure pointer - and register each port type once
> with the metrics lib.
>
> CC: stable@dpdk.org
> Fixes: fdbdb3f9ce46 ("telemetry: add initial connection socket")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Kevin, any comment please?
next prev parent reply other threads:[~2018-12-20 23:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 11:59 [PATCH] telemetry: fix error when using ports of different types Bruce Richardson
2018-12-20 23:51 ` Thomas Monjalon [this message]
2018-12-21 13:27 ` Laatz, Kevin
2018-12-21 15:33 ` [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35952782.MrcKBpYm8b@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.