From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akio Takebe <takebe_akio@jp.fujitsu.com>
Subject: Re: [Patch] cleanup pciback_reset_device
Date: Mon, 18 Dec 2006 22:26:56 +0900
Message-ID: <35C722A830293Ctakebe_akio@jp.fujitsu.com>
References: <C1AC10ED.5FF5%keir@xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C1AC10ED.5FF5%keir@xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir@xensource.com>, xen-devel@lists.xensource.com
Cc: Akio Takebe <takebe_akio@jp.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

Hi, Keir

>On 18/12/06 9:21 am, "Akio Takebe" <takebe_akio@jp.fujitsu.com> wrote:
>
>> This patch is for cleanup of pciback_reset_device.
>> is_enabled=0 and is_busmaster=0 are not necessary
>> because pci_disable_device() do them.
>
>If you are zapping the command register then doesn't it makes sense to zap
>the software flags relating to that at the same time, even if that sometimes
>happens to be redundant? It certainly means we can be sure they won't get
>out of sync.
>
I checked linux-2.6.19 and linux-2.6.18, 
both pci_disable_device()s do is_enabled=0 and is_busmaster=0.
I think pci_write_config_word(dev, PCI_COMMAND, 0) is not also necessary,
(though I'm not sure it.)

So I think they in pciback_reset_device() are not necessary.

But if you want to leave it for safe, I agree. :)

Best Regards,

Akio Takebe