From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=jae.hyun.yoo@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46P2Jb5ygMzDqPS for ; Thu, 5 Sep 2019 10:54:22 +1000 (AEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2019 17:54:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,468,1559545200"; d="scan'208";a="266844499" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.251.21.134]) ([10.251.21.134]) by orsmga001.jf.intel.com with ESMTP; 04 Sep 2019 17:54:20 -0700 Subject: Re: [PATCH dev-5.2 0/2] i2c: aspeed: Add H/W timeout support To: Andrew Jeffery , Joel Stanley Cc: Brendan Higgins , OpenBMC Maillist , Ryan Chen , Tao Ren References: <20190904200758.5420-1-jae.hyun.yoo@linux.intel.com> From: Jae Hyun Yoo Message-ID: <35ff4cb2-0cc7-ba53-da71-980cc11a09de@linux.intel.com> Date: Wed, 4 Sep 2019 17:54:18 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2019 00:54:25 -0000 On 9/4/2019 5:10 PM, Andrew Jeffery wrote: > > > On Thu, 5 Sep 2019, at 09:10, Jae Hyun Yoo wrote: >> Hi Andrew, >> >> On 9/4/2019 4:12 PM, Andrew Jeffery wrote: >>> On Thu, 5 Sep 2019, at 08:31, Jae Hyun Yoo wrote: >>>> Hi Joel, >>>> >>>> On 9/4/2019 3:54 PM, Joel Stanley wrote: >>>>> Hi Jae, >>>>> >>>>> On Wed, 4 Sep 2019 at 20:08, Jae Hyun Yoo wrote: >>>>>> >>>>>> In case of multi-master environment, if a peer master incorrectly handles >>>>>> a bus in the middle of a transaction, I2C hardware hangs in slave state >>>>>> and it can't escape from the slave state, so this commit adds slave >>>>>> inactive timeout support to recover the bus in the case. >>>>>> >>>>>> By applying this change, SDA data-low and SCL clock-low timeout feature >>>>>> also could be enabled which was disabled previously. >>>>> >>>>> Please consider sending your RFC patches to the upstream list. You >>>>> have a big backlog of patches now. >>>> >>>> Thanks for the reminding. I can't send the RFC patches yet because QEMU >>>> H/W model isn't ready yet. I'm still waiting for the fix from Cedric. >>> >>> QEMU shouldn't be preventing you from sending patches upstream, rather >>> it prevents us from enabling the buffer mode support in the OpenBMC >>> kernel tree. You should be sending all patches upstream as early as possible. >> >> I met a QEMU issue when I was upstreaming a patch set last year: >> https://lists.ozlabs.org/pipermail/linux-aspeed/2018-September/000750.html >> >> If OpenBMC community accepts the QEMU issue, I can submit the RFC >> patches to upstream. Will submit the patch set soon to linux tree. > > Ah, didn't realise it was Guenter that ran into it. We have some changes[1] in > Cedric's aspeed-4.2 qemu tree - do you mind testing it out? If those patches > resolve the issue Maybe we could point Guenter at that tree, though really we > should get the fixes upstream so this isn't an issue. > > [1] https://github.com/legoater/qemu/compare/59dda66ab756e52e6a9c1ef89660d30b3769f63c...aspeed-4.2 > Okay. I'll give it a try. Thanks, Jae