From: Akash M/Akash M <akash.m5@samsung.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>,
quic_wcheng@quicinc.com, hulianqin@vivo.com,
selvarasu.g@samsung.com
Cc: linux-usb@vger.kernel.org, cpgs@samsung.com,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>
Subject: Re: [[RFT PATCH v2] 0/2] xhci: sideband: fix use-after-free of stale virt device pointer
Date: Fri, 20 Nov 2026 16:17:04 +0530 [thread overview]
Message-ID: <360067785.01795176002867.JavaMail.epsvc@epcpadp1new> (raw)
In-Reply-To: <20261119214841.1552318-1-mathias.nyman@linux.intel.com>
On 11/20/2026 3:18 AM, Mathias Nyman wrote:
> Hi
>
> Second attempt.
> These two patches attempt to improve the disappearing vdev issue
> while sideband stays active.
>
> I don't have real harware to test this on so all review comments and
> feedback from testing is welcome.
Hi Mathias,
We tested USB Audio offload Playback and Capture, recursive
Connect/Disconnect on Exynos Mobile platforms and its working fine.
However its hard to reproduce the actual issue scenario where some
Control Transfers fail and xHC is reset and so we didn't test the issue
scenario.
Please feel free to add "Tested-by: Akash M <akash.m5@samsung.com>"
Regards,
Akash M
>
> There are still some gaps in how xhci driver uses locks when
> disabling slots and freeing vdev that is not part of this series
>
> changes since v1:
>
> - add missing sideband_to_vdev() check to xhci_sideband_create_interrupter()
> - fix ENOMEM return case in sideband_stop_endpoint_sync()
> - always clear sb->eps[ep_index] when removing an endpoint.
> - other minor changes
>
> Thanks
> Mathias
>
>
> Mathias Nyman (2):
> xhci: sideband: avoid use-after-free of stale virt device pointer
> xhci: sideband: check virt device under xhci lock when stopping
> endpoints
>
> drivers/usb/host/xhci-sideband.c | 151 ++++++++++++++++++++++--------
> drivers/usb/host/xhci.c | 55 -----------
> drivers/usb/host/xhci.h | 2 -
> include/linux/usb/xhci-sideband.h | 4 +-
> 4 files changed, 113 insertions(+), 99 deletions(-)
>
prev parent reply other threads:[~2026-11-20 12:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20261119214904epcas5p432ec8c5d6c3219c9434d64f210bca445@epcas5p4.samsung.com>
2026-11-19 21:48 ` [[RFT PATCH v2] 0/2] xhci: sideband: fix use-after-free of stale virt device pointer Mathias Nyman
2026-11-19 21:48 ` [[RFT PATCH v2] 1/2] xhci: sideband: avoid " Mathias Nyman
2026-11-19 21:53 ` sashiko-bot
2026-11-20 11:50 ` Selvarasu Ganesan
2026-11-19 21:48 ` [[RFT PATCH v2] 2/2] xhci: sideband: check virt device under xhci lock when stopping endpoints Mathias Nyman
2026-11-19 21:54 ` sashiko-bot
2026-11-20 11:51 ` Selvarasu Ganesan
2026-11-20 10:47 ` Akash M/Akash M [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=360067785.01795176002867.JavaMail.epsvc@epcpadp1new \
--to=akash.m5@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=cpgs@samsung.com \
--cc=hulianqin@vivo.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=quic_wcheng@quicinc.com \
--cc=selvarasu.g@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.