From: Abhinav Kumar <abhinavk@codeaurora.org>
To: Sean Paul <sean@poorly.run>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
Sean Paul <seanpaul@chromium.org>,
freedreno@lists.freedesktop.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/msm: dpu: Clear frame_busy_mask bit after trace
Date: Wed, 19 Sep 2018 13:01:01 -0700 [thread overview]
Message-ID: <3600ec1cb9451ad85a4a065bb10e82da@codeaurora.org> (raw)
In-Reply-To: <20180919183426.200909-1-sean@poorly.run>
On 2018-09-19 11:33, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> We're printing the frame_busy_mask in a trace, but after it's been
> cleared. This, as it turns out, is pretty pointless.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index c2e8985b4c54..e56f29190121 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -1361,9 +1361,9 @@ static void dpu_encoder_frame_done_callback(
> /* One of the physical encoders has become idle */
> for (i = 0; i < dpu_enc->num_phys_encs; i++) {
> if (dpu_enc->phys_encs[i] == ready_phys) {
> - clear_bit(i, dpu_enc->frame_busy_mask);
> trace_dpu_enc_frame_done_cb(DRMID(drm_enc), i,
> dpu_enc->frame_busy_mask[0]);
> + clear_bit(i, dpu_enc->frame_busy_mask);
> }
> }
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-09-19 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 18:33 [PATCH 1/3] drm/msm: dpu: Clear frame_busy_mask bit after trace Sean Paul
[not found] ` <20180919183426.200909-1-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-09-19 18:33 ` [PATCH 2/3] drm/msm: dpu: Add extra_flush_bits to trigger_flush trace Sean Paul
2018-09-19 20:01 ` Abhinav Kumar
2018-09-19 18:33 ` [PATCH 3/3] drm/msm: dpu: Don't store/deref pointers in trace ringbuffer Sean Paul
[not found] ` <20180919183426.200909-3-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-09-19 20:04 ` Abhinav Kumar
[not found] ` <84074f78534e74d92f1912846a4c570b-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-09-19 20:53 ` Sean Paul
2018-09-19 20:01 ` Abhinav Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3600ec1cb9451ad85a4a065bb10e82da@codeaurora.org \
--to=abhinavk@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.