Re: [PATCH v6] VFIO: Avoid to enable vfio while the module not loaded

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

2015-01-15 13:42, Burakov, Anatoly:
> Yep, apologies, it's my fault as it was my suggestion.
> I knew there was a linuxapp-only EAL header, for some reason I thought it's eal_private.
> Any suggestions on where to put this function? I don't think BSD needs this function. 

No, it's OK. I think it could be needed in bsd if a PMD
depends on a kernel driver or try to unload one.

PS: please don't top post
-- 
Thomas


> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > Sent: Thursday, January 15, 2015 1:38 PM
> > To: Qiu, Michael
> > Cc: Burakov, Anatoly; dev-VfR2kkLFssw@public.gmane.org; Xie, Huawei
> > Subject: Re: [PATCH v6] VFIO: Avoid to enable vfio while the module not
> > loaded
> > 
> > > > When vfio module is not loaded when kernel support vfio feature, the
> > > > routine still try to open the container to get file description.
> > > >
> > > > This action is not safe, and of cause got error messages:
> > > >
> > > > EAL: Detected 40 lcore(s)
> > > > EAL:   unsupported IOMMU type!
> > > > EAL: VFIO support could not be initialized
> > > > EAL: Setting up memory...
> > > >
> > > > This may make user confuse, this patch make it reasonable and much
> > > > more soomth to user.
> > > >
> > > > Signed-off-by: Michael Qiu <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > >
> > > Acked-by: Anatoly Burakov <anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > 
> > Note that rte_eal_check_module has no bsd counterpart.
> > It could be needed later.
> > 
> > Applied
> > 
> > Thanks
> > --
> > Thomas