All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Huawei Xie <huawei.xie@intel.com>, Tommy Long <thomas.long@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 2/2] vhost: realloc virtio_net and virtqueue to the same node of vring desc table
Date: Wed, 17 Jun 2015 19:02:22 +0200	[thread overview]
Message-ID: <3608606.ARMOZ1d8vj@xps13> (raw)
In-Reply-To: <4795082.KHkHrmv5EW@xps13>

2015-06-17 18:47, Thomas Monjalon:
> 2015-06-05 11:13, Huawei Xie:
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -92,6 +92,9 @@ endif # ! CONFIG_RTE_BUILD_COMBINE_LIBS
> >  
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP)       += -lpcap
> >  
> > +ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST)          += -lnuma
> > +
> >  ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n)
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST)          += -lfuse
> >  endif
> 
> An endif is missing.

After adding the endif and enabling the NUMA option, these errors appear:

lib/librte_vhost/virtio-net.c:535:21: error: ‘new_vq’ may be used uninitialized in this function
lib/librte_vhost/virtio-net.c:547:63: error: ‘new_ll_dev’ may be used uninitialized in this function

Tommy,
I won't review the code, but given it doesn't build, I can guess how it has
been reviewed.
Acked-by line is valuable only if the review is carefully done.

This patch series go back to lowest merge priority.

  reply	other threads:[~2015-06-17 17:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28  2:04 [PATCH RFC 0/2] vhost: numa aware allocation of virtio_net device and vhost virt queue Huawei Xie
2015-05-28  2:04 ` [PATCH RFC 1/2] vhost: malloc -> rte_malloc for virtio_net and virt queue allocation Huawei Xie
2015-05-28  2:04 ` [PATCH RFC 2/2] vhost: realloc virtio_net and virtqueue to the same node of vring desc table Huawei Xie
2015-06-03 23:38 ` [PATCH RFC 0/2] vhost: numa aware allocation of virtio_net device and vhost virt queue Long, Thomas
2015-06-05  3:13 ` [PATCH " Huawei Xie
2015-06-05  3:13   ` [PATCH 1/2] vhost: malloc -> rte_malloc for virtio_net and virt queue allocation Huawei Xie
2015-06-17 17:06     ` Thomas Monjalon
2015-06-05  3:13   ` [PATCH 2/2] vhost: realloc virtio_net and virtqueue to the same node of vring desc table Huawei Xie
2015-06-17 16:47     ` Thomas Monjalon
2015-06-17 17:02       ` Thomas Monjalon [this message]
2015-06-09  4:05   ` [PATCH 0/2] vhost: numa aware allocation of virtio_net device and vhost virt queue Long, Thomas
2015-06-18 16:59   ` [PATCH v2 0/2] vhost: numa aware allocation of vhost device and queues Huawei Xie
2015-06-18 16:59     ` [PATCH v2 1/2] vhost: use rte_malloc to allocate " Huawei Xie
2015-06-18 16:59     ` [PATCH v2 2/2] vhost: realloc vhost device and queues to the same numa node of vring desc table Huawei Xie
2015-06-25  5:47     ` [PATCH v3 0/2] vhost: numa aware allocation of vhost device and queues Huawei Xie
2015-06-25  5:47       ` [PATCH v3 1/2] vhost: use rte_malloc to allocate " Huawei Xie
2015-06-25  5:47       ` [PATCH v3 2/2] vhost: realloc vhost device and queues to the same numa node of vring desc table Huawei Xie
2015-06-29 17:04       ` [PATCH v3 0/2] vhost: numa aware allocation of vhost device and queues Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3608606.ARMOZ1d8vj@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=thomas.long@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.