Re: [master][PATCH v4 0/3] Devtool: provide easy means of

[Paul Eggleton <paul.eggleton@linux.intel.com>]

Hi Chandana,

Thanks! FYI the reason I bring this up is that it appears there's a problem with linux-yocto and SRCREV_machine values:

  https://bugzilla.yoctoproject.org/show_bug.cgi?id=13614

Would you be able to look into that as well?

Thanks
Paul

On Wednesday, 30 October 2019 12:03:35 PM NZDT Chandana Kalluri wrote:
> Hello Paul
> 
> Yes, I am in process of sending oeself test patches for devtool reset --remove-source command as commented In the other patch. I will also add the oeselftest for devtool kernel and send them out. 
> 
> Thanks,
> Chandana
> 
> > -----Original Message-----
> > From: Paul Eggleton <paul.eggleton@linux.intel.com>
> > Sent: Tuesday, October 29, 2019 3:52 PM
> > To: Chandana Kalluri <ckalluri@xilinx.com>
> > Cc: openembedded-core@lists.openembedded.org
> > Subject: Re: [OE-core] [OE-Core][master][PATCH v4 0/3] Devtool: provide easy
> > means of
> > 
> > Hi Chandana
> > 
> > Having added quite a bit to devtool relating to the kernel, we really ought to
> > extend our oe-selftest tests to cover the new functionality. Would you be able
> > to take care of that?
> > 
> > Thanks
> > Paul
> > 
> > On Wednesday, 5 June 2019 5:07:55 PM NZDT Paul Eggleton wrote:
> > > Hi Chandana
> > >
> > > My apologies for the delay in reviewing this - other work got in the way of
> > OE-Core contributions but that should be dealt with now.
> > >
> > > On Thursday, 18 April 2019 10:42:56 AM NZST Sai Hari Chandana Kalluri
> > wrote:
> > > > This patch series provides support for the user to run menuconfig
> > > > command in the devtool flow. This would allow the user to modify the
> > > > current configurations and generate a config fragment to update the
> > > > recipe using devtool finish. Devtool menuconfig command will work on all
> > packages that contain menuconfig as a task.
> > > >
> > > > 1. The implementation checks if devtool menuconfig command is called
> > > > for a valid package.
> > > > 2. It checks for oe-local-files dir within source and creates one if
> > > > needed, this directory is needed to store the final generated config
> > > > fragment so that devtool finish can update the recipe.
> > > > 3. Menuconfig command is called for users to make necessary changes.
> > > > After saving the changes, diffconfig command is run to generate the
> > fragment.
> > > >
> > > > Currently, when the user runs devtool modify command, it checks out
> > > > the entire source tree which is a bit of an over head in time and
> > > > space. This patch series also provides a way to create a copy(hard
> > > > links) of the kernel source, if present, from work-shared to workspace to be
> > more efficient .
> > > >
> > > > Also, if the kernel source is not present in the staging kernel dir
> > > > and the user fetches the source tree in workspace using devtool
> > > > modify, then this patch series creates a copy of source from
> > > > workspace to work-shared. This is necessary for packages that may use the
> > kernel source.
> > >
> > > Looking over the patches again, we're close but the following need to be
> > corrected:
> > >
> > > 1) The devtool.DevtoolUpdateTests.test_devtool_update_recipe_local_files
> > test in oe-selftest fails:
> > >
> > > ---------------- snip ----------------
> > > INFO: Adding local source files to srctree...
> > > Traceback (most recent call last):
> > >   File "/data/poky/scripts/devtool", line 334, in <module>
> > >     ret = main()
> > >   File "/data/poky/scripts/devtool", line 321, in main
> > >     ret = args.func(args, config, basepath, workspace)
> > >   File "/data/poky/scripts/lib/devtool/standard.py", line 845, in modify
> > >     initial_rev, _ = _extract_source(srctree, args.keep_temp, args.branch,
> > False, config, basepath, workspace, args.fixed_setup, rd, tinfoil,
> > no_overrides=args.no_overrides)
> > >   File "/data/poky/scripts/lib/devtool/standard.py", line 657, in
> > _extract_source
> > >     symblink_oelocal_files_srctree(d,srctree)
> > >   File "/data/poky/scripts/lib/devtool/standard.py", line 485, in
> > symblink_oelocal_files_srctree
> > >     oe.patch.GitApplyTree.gitCommandUserOptions(useroptions, d=d)
> > > NameError: name 'oe' is not defined
> > > ---------------- snip ----------------
> > >
> > > Probably just a missing import.
> > >
> > > 2) Please change "symblink" to "symlink"
> > >
> > > 3) Indentation is very inconsistent in the added code. Please use four spaces
> > everywhere.
> > >
> > > I would also like to see oe-selftest tests covering this functionality, but I
> > won't require them to ack these patches (especially given the delays on my
> > part).
> > >
> > > Thanks
> > > Paul
> > >
> > >
> > 
> > 
> > --
> > 
> > Paul Eggleton
> > Intel System Software Products
> > 
> 
> 


-- 

Paul Eggleton
Intel System Software Products