From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B256C38A24 for ; Thu, 7 May 2020 14:58:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D1E720663 for ; Thu, 7 May 2020 14:58:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D1E720663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B4A786E9D4; Thu, 7 May 2020 14:58:39 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DA616E9D4 for ; Thu, 7 May 2020 14:58:38 +0000 (UTC) IronPort-SDR: qULMp4Tk3JqXCvYiLEptEoQrcy6+jZWD1Ntc7aYBSXvOl/EPWfElhjKBWm7VjcTg1hvTwU18u0 fxLi/PsMaYJQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 07:58:38 -0700 IronPort-SDR: G+LeVH9FsPLPSmDqZwy8r7PLj6Sabr9qwtWREFZ02SxxwK8bnd0i746M1nr6wDGKdDa4kTl6hA eW5zQXaGcG4A== X-IronPort-AV: E=Sophos;i="5.73,364,1583222400"; d="scan'208";a="435313939" Received: from nstgemme-mobl1.ger.corp.intel.com (HELO [10.252.42.100]) ([10.252.42.100]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 07:58:37 -0700 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20200507082124.1673-1-chris@chris-wilson.co.uk> <20200507082124.1673-3-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <360b7bf2-a1ce-c028-0061-3a90641b18d2@linux.intel.com> Date: Thu, 7 May 2020 15:58:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200507082124.1673-3-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: Treat weak-dependencies as bidirectional when applying priorities X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 07/05/2020 09:21, Chris Wilson wrote: > Clients may use a submit-fence as bidirectional bond between two or more > co-operating requests, and so if we bump the priority of one, we wish to > bump the priority of the set. > > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/i915_scheduler.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c > index 6e2d4190099f..7194fbfcaa49 100644 > --- a/drivers/gpu/drm/i915/i915_scheduler.c > +++ b/drivers/gpu/drm/i915/i915_scheduler.c > @@ -291,6 +291,12 @@ static void __i915_schedule(struct i915_sched_node *node, > if (prio > READ_ONCE(p->signaler->attr.priority)) > list_move_tail(&p->dfs_link, &dfs); > } > + > + list_for_each_entry(p, &node->waiters_list, wait_link) { > + if (p->flags & I915_DEPENDENCY_WEAK && > + prio > READ_ONCE(p->waiter->attr.priority)) > + list_move_tail(&p->dfs_link, &dfs); > + } > } > > /* > Reviewed-by: Tvrtko Ursulin Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx