From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Weiguo Li <liwg06@foxmail.com>, dev@dpdk.org
Subject: Re: [PATCH v3 1/4] kni: add define guards to avoid multi-inclusion
Date: Tue, 22 Feb 2022 15:48:33 +0100 [thread overview]
Message-ID: <3610695.tlMGI8NQbM@thomas> (raw)
In-Reply-To: <552086d6-dfa9-de92-8e97-92543ac0e722@intel.com>
09/02/2022 14:52, Ferruh Yigit:
> On 2/9/2022 7:24 AM, Weiguo Li wrote:
> > +#ifndef RTE_KNI_FIFO_H
> > +#define RTE_KNI_FIFO_H
>
> It doesn't really differ much but other kni header guards wrapped with '_',
> I don't now why.
No good reason I think.
> If there will be a new version can you please apply the same here to have
> consistency, like:
> #ifndef _RTE_KNI_FIFO_H_
I think consistency is not important here.
We should not add underscores where not needed,
it gives a false impression of reserved keywords.
next prev parent reply other threads:[~2022-02-22 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1644390801.git.liwg06@foxmail.com>
2022-02-09 7:24 ` [PATCH v3 1/4] kni: add define guards to avoid multi-inclusion Weiguo Li
2022-02-09 13:52 ` Ferruh Yigit
2022-02-22 14:48 ` Thomas Monjalon [this message]
2022-02-09 7:24 ` [PATCH v3 2/4] eal: " Weiguo Li
2024-10-03 23:58 ` Stephen Hemminger
2022-02-09 7:24 ` [PATCH v3 3/4] efd: " Weiguo Li
2024-10-03 23:59 ` Stephen Hemminger
2022-02-09 7:24 ` [PATCH v3 4/4] hash: " Weiguo Li
2024-10-03 23:57 ` Stephen Hemminger
2024-10-15 22:56 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3610695.tlMGI8NQbM@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=liwg06@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.