From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts Date: Sun, 23 Oct 2016 19:55:29 -0700 Message-ID: <36163853-ac4a-e146-0c1b-eaf42e8b234d@codeaurora.org> References: <1477067879-23750-1-git-send-email-okaya@codeaurora.org> <1477067879-23750-5-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35210 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756116AbcJXCzf (ORCPT ); Sun, 23 Oct 2016 22:55:35 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Andy Shevchenko Cc: dmaengine , Timur Tabi , devicetree , Christopher Covington , Vinod Koul , Jon Masters , Andy Gross , Arnd Bergmann , linux-arm-msm@vger.kernel.org, linux-arm Mailing List , Dan Williams , Dave Jiang , Lars-Peter Clausen , "linux-kernel@vger.kernel.org" On 10/21/2016 12:11 PM, Andy Shevchenko wrote: >> +static void hidma_free_msis(struct hidma_dev *dmadev) >> > +{ >> > +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN > Perhaps one #ifdef and two definitions of functions? I don't think it will make a difference. I'll have to move #ifdef around the caller of hidma_free_msis instead which I think is uglier. The hidma_write_msi_msg function gets called only when CONFIG_GENERIC_MSI_IRQ_DOMAIN is defined. If I don't put this around the function definition, I get unused function warning from the compiler. This is the reason why preprocessor definition is outside of the function definition. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org (Sinan Kaya) Date: Sun, 23 Oct 2016 19:55:29 -0700 Subject: [PATCH V7 4/4] dmaengine: qcom_hidma: add MSI support for interrupts In-Reply-To: References: <1477067879-23750-1-git-send-email-okaya@codeaurora.org> <1477067879-23750-5-git-send-email-okaya@codeaurora.org> Message-ID: <36163853-ac4a-e146-0c1b-eaf42e8b234d@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/21/2016 12:11 PM, Andy Shevchenko wrote: >> +static void hidma_free_msis(struct hidma_dev *dmadev) >> > +{ >> > +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN > Perhaps one #ifdef and two definitions of functions? I don't think it will make a difference. I'll have to move #ifdef around the caller of hidma_free_msis instead which I think is uglier. The hidma_write_msi_msg function gets called only when CONFIG_GENERIC_MSI_IRQ_DOMAIN is defined. If I don't put this around the function definition, I get unused function warning from the compiler. This is the reason why preprocessor definition is outside of the function definition. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.