From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v5 5/8] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device Date: Sun, 29 Jan 2017 21:30:13 +0100 Message-ID: <3616490.5RPja2j5kp@phil> References: <1485260203-14216-1-git-send-email-al.kochet@gmail.com> <3890508.0j97LNriXL@diego> <14EAE124-D504-4480-A6D4-EB7EFFC3C561@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <14EAE124-D504-4480-A6D4-EB7EFFC3C561@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Alexander Kochetkov Cc: Mark Rutland , devicetree@vger.kernel.org, Huang Tao , Daniel Lezcano , LKML , Russell King , linux-rockchip@lists.infradead.org, Rob Herring , Thomas Gleixner , LAK , Caesar Wang List-Id: linux-rockchip.vger.kernel.org SGkgQWxleGFuZGVyLAoKQW0gRGllbnN0YWcsIDI0LiBKYW51YXIgMjAxNywgMTg6MTY6MjAgQ0VU IHNjaHJpZWIgQWxleGFuZGVyIEtvY2hldGtvdjoKPiA+IDI0INGP0L3Qsi4gMjAxNyDQsy4sINCy IDE4OjAyLCBIZWlrbyBTdMO8Ym5lciA8aGVpa29Ac250ZWNoLmRlPiDQvdCw0L/QuNGB0LDQuyjQ sCk6Cj4gPiAKPiA+IFBsZWFzZSBkb24ndCBhZGQgUmV2aWV3ZWQtYnkgdGFncyB3aXRob3V0IGV4 cGxpY2l0IG1lbnRpb24gb2YgdGhlbSBieQo+ID4gcmV2aWV3ZXJzLiAoQWxzbyBpdCdzIHNwZWxs ZWQgd3JvbmcpLgo+ID4gCj4gPiBJIGhhdmVuJ3QgbG9va2VkIHRoYXQgZGVlcGx5IGludG8gdGhl IGRyaXZlciBpdHNlbGYgYW5kIHRoZSBjaGFuZ2VzIG1hZGUKPiA+IHRvCj4gPiBmZWVsIGNvbWZv cnRhYmxlIHdpdGggYSAiUmV2aWV3ZWQtYnkiLgo+IAo+IFRoYW4gSSBwb3N0ZWQgYW5vdGhlciBs aW51eCBjb2RlIEkgd2FzIGFza2VkIHRvIGFkZCBzdWNoIHRhZ3MgKGFuZCBvdGhlcnMpCj4gdG8g YWRkIGNyZWRpdHMgdG8gcGVvcGxlLgo+IAo+IFNvcnJ5IGZvciB0aGF0LgoKbm8gcHJvYmxlbS4g SW4gZ2VuZXJhbCBwZW9wbGUgcmV2aWV3aW5nIHBhdGNoZXMgd2lsbCByZXNwb25kIHRvIHRoZSBw YXRjaCB3aXRoIAp0YWdzIHRoZXkgYXJlIGNvbWZvcnRhYmxlIHdpdGggYmVpbmcgYWRkZWQuIEFu ZCBhIFJldmlld2VkLWJ5IGlzIGEgcHJldHR5IApzdHJvbmcgdGFnLCBpbmRpY2F0aW5nIHRoYXQg c29tZSB0aG91Z2h0IHdlbnQgaW50byByZXZpZXdpbmcgYSBzcGVjaWZpYyBwYXRjaCwgCndoaWNo IEkgaGFkbid0IGRvbmUgd2l0aCBteSBjdXJzb3J5IGdsYW5jZSBhdCB0aGUgdGltZSA6LSkKCkhl aWtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Sun, 29 Jan 2017 21:30:13 +0100 Subject: [PATCH v5 5/8] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device In-Reply-To: <14EAE124-D504-4480-A6D4-EB7EFFC3C561@gmail.com> References: <1485260203-14216-1-git-send-email-al.kochet@gmail.com> <3890508.0j97LNriXL@diego> <14EAE124-D504-4480-A6D4-EB7EFFC3C561@gmail.com> Message-ID: <3616490.5RPja2j5kp@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Alexander, Am Dienstag, 24. Januar 2017, 18:16:20 CET schrieb Alexander Kochetkov: > > 24 ???. 2017 ?., ? 18:02, Heiko St?bner ???????(?): > > > > Please don't add Reviewed-by tags without explicit mention of them by > > reviewers. (Also it's spelled wrong). > > > > I haven't looked that deeply into the driver itself and the changes made > > to > > feel comfortable with a "Reviewed-by". > > Than I posted another linux code I was asked to add such tags (and others) > to add credits to people. > > Sorry for that. no problem. In general people reviewing patches will respond to the patch with tags they are comfortable with being added. And a Reviewed-by is a pretty strong tag, indicating that some thought went into reviewing a specific patch, which I hadn't done with my cursory glance at the time :-) Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322AbdA2Ubg convert rfc822-to-8bit (ORCPT ); Sun, 29 Jan 2017 15:31:36 -0500 Received: from gloria.sntech.de ([95.129.55.99]:45718 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbdA2UbT (ORCPT ); Sun, 29 Jan 2017 15:31:19 -0500 From: Heiko Stuebner To: Alexander Kochetkov Cc: Daniel Lezcano , LKML , devicetree@vger.kernel.org, LAK , linux-rockchip@lists.infradead.org, Thomas Gleixner , Mark Rutland , Rob Herring , Russell King , Caesar Wang , Huang Tao Subject: Re: [PATCH v5 5/8] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device Date: Sun, 29 Jan 2017 21:30:13 +0100 Message-ID: <3616490.5RPja2j5kp@phil> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <14EAE124-D504-4480-A6D4-EB7EFFC3C561@gmail.com> References: <1485260203-14216-1-git-send-email-al.kochet@gmail.com> <3890508.0j97LNriXL@diego> <14EAE124-D504-4480-A6D4-EB7EFFC3C561@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexander, Am Dienstag, 24. Januar 2017, 18:16:20 CET schrieb Alexander Kochetkov: > > 24 янв. 2017 г., в 18:02, Heiko Stübner написал(а): > > > > Please don't add Reviewed-by tags without explicit mention of them by > > reviewers. (Also it's spelled wrong). > > > > I haven't looked that deeply into the driver itself and the changes made > > to > > feel comfortable with a "Reviewed-by". > > Than I posted another linux code I was asked to add such tags (and others) > to add credits to people. > > Sorry for that. no problem. In general people reviewing patches will respond to the patch with tags they are comfortable with being added. And a Reviewed-by is a pretty strong tag, indicating that some thought went into reviewing a specific patch, which I hadn't done with my cursory glance at the time :-) Heiko