From: Nilay Shroff <nilay@linux.ibm.com>
To: Yu Kuai <yukuai@fnnas.com>,
axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, tj@kernel.org, ming.lei@redhat.com
Subject: Re: [PATCH RESEND 4/5] blk-iolatency: fix incorrect lock order for rq_qos_mutex and freeze queue
Date: Mon, 17 Nov 2025 15:42:17 +0530 [thread overview]
Message-ID: <3622d80b-2946-4f0d-bb64-eb4eadf78dbf@linux.ibm.com> (raw)
In-Reply-To: <20251116041024.120500-5-yukuai@fnnas.com>
On 11/16/25 9:40 AM, Yu Kuai wrote:
> Currently blk-iolatency will hold rq_qos_mutex first and then call
> rq_qos_add() to freeze queue.
>
> Fix this problem by converting to use blkg_conf_open_bdev_frozen()
> from iolatency_set_limit(), and convert to use rq_qos_add_freezed().
>
> Signed-off-by: Yu Kuai <yukuai@fnnas.com>
Looks good to me:
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
next prev parent reply other threads:[~2025-11-17 10:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 4:10 [PATCH RESEND 0/5] block/blk-rq-qos: fix incorrect lock order for rq_qos_mutex and freeze queue Yu Kuai
2025-11-16 4:10 ` [PATCH RESEND 1/5] block/blk-rq-qos: add a new helper rq_qos_add_freezed() Yu Kuai
2025-11-17 10:10 ` Nilay Shroff
2025-11-17 11:01 ` Ming Lei
2025-11-17 11:13 ` Nilay Shroff
2025-11-17 11:30 ` Ming Lei
2025-11-17 11:39 ` Yu Kuai
2025-11-17 11:54 ` Ming Lei
2025-11-17 11:59 ` Yu Kuai
2025-11-17 23:32 ` Bart Van Assche
2025-11-16 4:10 ` [PATCH RESEND 2/5] blk-wbt: fix incorrect lock order for rq_qos_mutex and freeze queue Yu Kuai
2025-11-17 10:11 ` Nilay Shroff
2025-11-19 6:55 ` kernel test robot
2025-11-16 4:10 ` [PATCH RESEND 3/5] blk-iocost: " Yu Kuai
2025-11-17 10:11 ` Nilay Shroff
2025-11-16 4:10 ` [PATCH RESEND 4/5] blk-iolatency: " Yu Kuai
2025-11-17 10:12 ` Nilay Shroff [this message]
2025-11-16 4:10 ` [PATCH RESEND 5/5] block/blk-rq-qos: cleanup rq_qos_add() Yu Kuai
2025-11-17 10:13 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3622d80b-2946-4f0d-bb64-eb4eadf78dbf@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tj@kernel.org \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.