From: Thomas Monjalon <thomas@monjalon.net>
To: jerinj@marvell.com
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>,
Jianfeng Tan <jianfeng.tan@intel.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix build errors
Date: Tue, 30 Jul 2019 19:47:23 +0200 [thread overview]
Message-ID: <3632593.gczBNArdAd@xps> (raw)
In-Reply-To: <8ed9b94d-d884-c774-6600-3a59c929ed08@redhat.com>
30/07/2019 18:12, Maxime Coquelin:
> On 7/30/19 1:04 PM, jerinj@marvell.com wrote:
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > Add extern to variable declaration to avoid some compiler treating it
> > as variable definition.
> >
> > build error log:
> >
> > lib/librte_pmd_virtio.a(vhost_kernel.o):(.rodata+0x110):
> > multiple definition of `vhost_msg_strings'
> > lib/librte_pmd_virtio.a(vhost_user.o):(.data.rel.ro.local+0x0):
> > first defined here
> > lib/librte_pmd_virtio.a(virtio_user_dev.o):(.rodata+0xe8):
> > multiple definition of `vhost_msg_strings'
> > lib/librte_pmd_virtio.a(vhost_user.o):(.data.rel.ro.local+0x0):
> > first defined here
> >
> > Fixes: 33d24d65fe2b ("net/virtio-user: abstract backend operations")
> >
> > Cc: Jianfeng Tan <jianfeng.tan@intel.com>
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Applied, thanks
prev parent reply other threads:[~2019-07-30 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 11:04 [dpdk-dev] [PATCH] net/virtio: fix build errors jerinj
2019-07-30 16:12 ` Maxime Coquelin
2019-07-30 17:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3632593.gczBNArdAd@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.