From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v7 2/2] cryptodev: change burst API to be
	crypto op oriented
Date: Tue, 08 Mar 2016 15:32:02 +0100
Message-ID: <3632610.NvqD1GaQY3@xps13>
References: <1457116189-10226-1-git-send-email-fiona.trahe@intel.com>
 <1457351422-7617-3-git-send-email-fiona.trahe@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Fiona Trahe <fiona.trahe@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id E8CD32BDA
 for <dev@dpdk.org>; Tue,  8 Mar 2016 15:33:40 +0100 (CET)
Received: by mail-wm0-f42.google.com with SMTP id n186so134484017wmn.1
 for <dev@dpdk.org>; Tue, 08 Mar 2016 06:33:40 -0800 (PST)
In-Reply-To: <1457351422-7617-3-git-send-email-fiona.trahe@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-07 11:50, Fiona Trahe:
> This patch modifies the crypto burst enqueue/dequeue APIs to operate on bursts
> rte_crypto_op's rather than the current implementation which operates on
> rte_mbuf bursts, this simplifies the burst processing in the crypto PMDs and the
> use of crypto operations in general.
> 
> The changes also continues the separatation of the symmetric operation parameters
> from the more general operation parameters, this will simplify the integration of
> asymmetric crypto operations in the future.
> 
> As well as the changes to the crypto APIs this patch adds functions for managing
> rte_crypto_op pools to the cryptodev API. It modifies the existing PMDs, unit
> tests and sample application to work with the modified APIs and finally
> removes the now unused rte_mbuf_offload library.

Why not doing several patches?

> -Packet buffer offload - EXPERIMENTAL
> -M: Declan Doherty <declan.doherty@intel.com>
> -F: lib/librte_mbuf_offload/

Removing a library is important. It is not mentioned in the message.
It deserves a separate commit, please.

> @@ -62,8 +61,7 @@ struct crypto_unittest_params {
>  
>  	struct rte_cryptodev_sym_session *sess;
>  
> -	struct rte_mbuf_offload *ol;
> -	struct rte_crypto_sym_op *op;
> +	struct rte_crypto_op *op;

Isn't it something which was just renamed in the previous patch?

> -#if HEX_DUMP
> +#ifdef HEX_DUMP
>  static void
>  hexdump_mbuf_data(FILE *f, const char *title, struct rte_mbuf *m)

A better clean-up would be to remove this ifdef.
If you need a debug function which is not already in EAL, you can
consider adding it.