From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76D49C35274 for ; Thu, 21 Dec 2023 10:34:40 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.658797.1028169 (Exim 4.92) (envelope-from ) id 1rGGNq-0001sP-0J; Thu, 21 Dec 2023 10:34:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 658797.1028169; Thu, 21 Dec 2023 10:34:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rGGNp-0001sI-Tb; Thu, 21 Dec 2023 10:34:29 +0000 Received: by outflank-mailman (input) for mailman id 658797; Thu, 21 Dec 2023 10:34:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rGGNo-0001fa-3Q for xen-devel@lists.xenproject.org; Thu, 21 Dec 2023 10:34:28 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 841ece09-9fec-11ee-98eb-6d05b1d4d9a1; Thu, 21 Dec 2023 11:34:27 +0100 (CET) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40d31116dbeso7036245e9.3 for ; Thu, 21 Dec 2023 02:34:27 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id i5-20020a05600c354500b0040d2805d158sm2755029wmq.48.2023.12.21.02.34.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Dec 2023 02:34:26 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 841ece09-9fec-11ee-98eb-6d05b1d4d9a1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1703154867; x=1703759667; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=xKp0lfNdj4JAZmeaj9cRG9ojnk5+dhWB0fRogF/fZqo=; b=UozH2ewwUcjcjWxK6M3UTeXR+StWuaB9/Amzz9x+0xoLSVzbrKvR7LRvRjN5SUKpQ0 IV9AlmyGkaEkfEbvyAg/i1ZBtrST+WNGV/dq30dyuLKfLZqNg6g6UBBhk8fGVPhfCg0o rms7z9IUQR470X++RkRzrl0v7CiRVS1cHoi1iOVqEgnRjFJ/rMWwRf3BxZdgjbdZxctb Eq6b6ChEvxSEi6TX8f2W5FjyioCWJ8f+muOa88AZf+61hfOIPn16oeXOCsOdh/d+qrTY qqBSDgXFDl4RtNuP0iG+l5wAj1YMtbsfJuPs/GBEU4oQebW54k9OEhFUumyu6VQNqUx4 BdKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703154867; x=1703759667; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xKp0lfNdj4JAZmeaj9cRG9ojnk5+dhWB0fRogF/fZqo=; b=ggoCxBEevSKsafIgv5OqcGiD3L+jwmNgEsbSXsApIaYXFahkqOA4qXfue60dy21JWr a4otr33gKo2HkHD4QYW7wsqVFszHs+iHq6Vz+LRi9rgvSAyIakWbVV9qnyUlc2aHOO/B LNx8AfbWq+A/Ncr8gn0kavku6Mp0ewlsmr2/4PE07r3xCSjHNLjt2o3glUzBLVM1VNsY jgPjiWCS5AwP5Wpx+zN7fsLkQwclRdqaU/MRbj3LcA+bMmIVJE4HJQWyjyOLsZVIj/NA bhr0Q83kvnSqkCyEHvpJy+EynRuDC4ezlUGjF93zj1b3wCmX8TxC8G2KnZrbvomumxYK YtSQ== X-Gm-Message-State: AOJu0Yx0SM9NT/vqYMGuBzPtH+fOHGF+5RDgJKfCdfm013Xd+qW06MJc GSUPJiMXtbdlRTw31RXm2n/n X-Google-Smtp-Source: AGHT+IHtXX/iODG9BQzn6/PIrI2oOLjhjbyiIRLwV3mEjwdzqxNE/UQxBUTs77GnnQQKXEVQA0G4wQ== X-Received: by 2002:a05:600c:280b:b0:40d:22bb:27e9 with SMTP id m11-20020a05600c280b00b0040d22bb27e9mr589565wmb.53.1703154866812; Thu, 21 Dec 2023 02:34:26 -0800 (PST) Message-ID: <36331c0f-d495-4263-95a6-e1c5abcac060@suse.com> Date: Thu, 21 Dec 2023 11:34:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/12] xen/spinlock: introduce new type for recursive spinlocks To: Julien Grall , Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap , Stefano Stabellini , Paul Durrant References: <20231212094725.22184-1-jgross@suse.com> <20231212094725.22184-4-jgross@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12.12.2023 13:57, Julien Grall wrote: > On 12/12/2023 09:47, Juergen Gross wrote: >> @@ -109,12 +109,16 @@ struct lock_profile_qhead { >> spinlock_t l = _SPIN_LOCK_UNLOCKED(NULL); \ >> static struct lock_profile __lock_profile_data_##l = _LOCK_PROFILE(l); \ >> _LOCK_PROFILE_PTR(l) >> +#define DEFINE_RSPINLOCK(l) \ >> + rspinlock_t l = _SPIN_LOCK_UNLOCKED(NULL); \ >> + static struct lock_profile __lock_profile_data_##l = _LOCK_PROFILE(l); \ >> + _LOCK_PROFILE_PTR(l) >> >> -#define spin_lock_init_prof(s, l) \ >> +#define __spin_lock_init_prof(s, l, locktype) \ > > If I am not mistaken the double-underscore prefix is a violation in > MISRA. So can this be renamed to: > > spin_lock_init_prof__()? Is the new parameter needed at all? Can't we use typeof((s)->l) in place of passing the type explicitly? Jan