Re: [PATCH v6 00/47] TruFlow update for Thor2

[Thomas Monjalon <thomas@monjalon.net>]

24/10/2024 07:26, Ajit Khaparde:
> On Mon, Oct 21, 2024 at 1:14 AM Sriharsha Basavapatna
> <sriharsha.basavapatna@broadcom.com> wrote:
> >
> > This patch series introduces TruFlow functionality for Broadcom Thor2 NIC.
> >
> > TruFlow(TF) is the software library that exposes CFA HW resources to
> > upper layer protocols or applications. This patch series implements the
> > tfc (tf_core) and the tf_ulp libraries as a part of the bnxt PMD,
> > so that upper layer APIs such as rte_flow can access the hardware.
> 
> Patchset applied to dpdk-next-net-brcm for-next-net branch.
> Along the way, I fixed up some commit logs,
> checkpatch errors, spelling errors, long lines and EOF errors -
> wherever possible.
> Some of the patches are auto generated and could not be modified.
> The autogen scripts are being updated to fix them for the next round
> of submissions.

There are still too many issues.
Please could you fix these warnings before we can merge?


+drivers/net/bnxt/tf_core/v3/tfc_global_id.c: duplicated include: tfc.h
+drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c: duplicated include: bnxt.h
+drivers/net/bnxt/tf_core/v3/tfc_tcam.c: duplicated include: tfc.h
Missing 'Fixes' tag:
        net/bnxt: tf_core: fix slice count in case of HA entry move
        net/bnxt: tf_ulp: fixed parent child db counters
Is it candidate for Cc: stable@dpdk.org backport?
        net/bnxt: fix issue reading sff8436 sfp eeproms
        net/bnxt: tf_core: fix wc tcam multi slice delete issue
        net/bnxt: tf_core: tcam manager data corruption
        net/bnxt: tf_core: Thor TF EM key size check
Wrong tag order: 
        net/bnxt: tf_core: fix wc tcam multi slice delete issue (Signed-off-by:)
Contributor name/email mismatch with .mailmap: 
        Peter Morrow <peter@graphiant.com> is unknown in .mailmap

Writing to stdout or stderr

Do not use variadic argument pack in macros

Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE

Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx

Using __builtin helpers for bit count operations

Error parsing drivers/net/bnxt/tf_core/v3/meson.build:15, got some tabulation
Error: Missing trailing "," in list at drivers/net/bnxt/tf_core/v3/meson.build:33
Error parsing drivers/net/bnxt/hcapi/cfa_v3/meson.build:10, got some tabulation
Error parsing drivers/net/bnxt/tf_ulp/meson.build:27, got some tabulation
Error parsing drivers/net/bnxt/tf_ulp/generic_templates/meson.build:6, got some tabulation

rte_flow doc out of sync for bnxt
        item geneve
        item vxlan_gpe
        action set_ipv6_dst
        action set_ipv6_src
        action set_ttl


WARNING:TYPO_SPELLING: 'pupose' may be misspelled - perhaps 'purpose'?
#6584: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/host/cfa_bld_mpcops.h:72:
+ * optional and can be filled with a null pointer. The pupose of these hooks
                                                        ^^^^^^

WARNING:TYPO_SPELLING: 'Foward' may be misspelled - perhaps 'Forward'?
#7219: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_bld_p70_defs.h:103:
+       /** Set to statistic to Foward packet count(64b)/Foward byte
                                ^^^^^^

WARNING:TYPO_SPELLING: 'Foward' may be misspelled - perhaps 'Forward'?
#7219: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_bld_p70_defs.h:103:
+       /** Set to statistic to Foward packet count(64b)/Foward byte
                                                         ^^^^^^

WARNING:TYPO_SPELLING: 'modfication' may be misspelled - perhaps 'modification'?
#7389: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_bld_p70_defs.h:273:
+               /** Set to true to enable modfication
                                          ^^^^^^^^^^^

WARNING:TYPO_SPELLING: 'Conifiguration' may be misspelled - perhaps 'Configuration'?
#11468: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_p70_hw.h:1531:
+ * Mirror Destination 1 Sampling Conifiguration.
                                  ^^^^^^^^^^^^^^

WARNING:TYPO_SPELLING: 'wit' may be misspelled - perhaps 'with'?
#14002: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_p70_hw.h:4065:
+       /* Add one VLAN tag remap wit inner VLAN Tag PRI field. */
                                  ^^^
WARNING:TYPO_SPELLING: 'inluding' may be misspelled - perhaps 'including'?
#14325: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_p70_mpc_structs.h:96:
+        * cases (inluding EM_INSERT bucket writes), the OPTION field is set by
                  ^^^^^^^^

WARNING:TYPO_SPELLING: 'explicity' may be misspelled - perhaps 'explicitly'?
#15271: FILE: drivers/net/bnxt/hcapi/cfa_v3/bld/include/p70/cfa_p70_mpc_structs.h:1042:
+ * wishes to explicity delete the matching entry. * REPLACE=1:
              ^^^^^^^^^

WARNING:TYPO_SPELLING: 'alloced' may be misspelled - perhaps 'allocated'?
#50280: FILE: drivers/net/bnxt/tf_core/v3/tfo.c:18:
+       bool ts_is_bs_owner; /**< Backing store alloced by this instance (PF) */
                                                ^^^^^^^

WARNING:TYPO_SPELLING: 'paranthesis' may be misspelled - perhaps 'parenthesis'?
#20: 
        paranthesis.
        ^^^^^^^^^^^

WARNING:TYPO_SPELLING: 'firmwware' may be misspelled - perhaps 'firmware'?
#3466: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:967:
+ * the firmwware.