From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6951472733283680256 X-Received: by 2002:a5d:6b50:: with SMTP id x16mr5331197wrw.379.1618520347874; Thu, 15 Apr 2021 13:59:07 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 2002:a5d:6804:: with SMTP id w4ls3272409wru.2.gmail; Thu, 15 Apr 2021 13:59:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwImnxLpzeY8V7+LP+VoERypT0WuZk7ZDIv97jsOxf8oOyiCW3PPIgZK5aV3XcPw/bXk5eK X-Received: by 2002:adf:facf:: with SMTP id a15mr5414820wrs.261.1618520346445; Thu, 15 Apr 2021 13:59:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618520346; cv=none; d=google.com; s=arc-20160816; b=b6Amn5ANhRtW9bKNhpw8OheGsFlqdcEoPqYVXdsrpgLCLr2WyhUVOTs1PubrCDc09L yVuk14ywv3z7uVL/lXMdFWpDpPgQowfB+4kj0u+Bbq2rJ2RDcHq73Gqy9v44vEduVGNu fnLuu+F7Jef9o26phO3dSNaXnc5g3MJIE+JFNUOR1uOLYkDb9dZRePs1vvxZx1hXnuQD wUtOlXi/VfiC88KtwxwBKUSyt8AVU2t+/YGj7TIQS8j+pAsWe2f4J6D1qQqyoW4XfP67 XwyIbuOWdx/Qull0BsyJMO4wBuFeU57x+tPOFQE0GpvZqfupzwWEK77OX0AJxo9MEMno K11g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=VqKz8czkX08y+e0ZGB+BKN4E0AUfG/jjvVBjvYwbxEo=; b=dBxVUMBtxlYa9WrSl2mTbhlaXC7uOz2zXyNsFE7hcdu6AiYRIKm5PaxeAvZi+k3J2N 13QUpJYJx622wp59bsf6ntIuEaN9L6MPasfoXsT9YDpX3StW5yA54HkEYohTvvjreSLk gPEQUvhvutcmoOKi5k0Memni9ii+sQqzKkLGwqdNWJa5LDLdbq3SEEQGRXwlB2hRNm5G 5SsgePvX2hrAxdhh5Y8CWRHLROGHIdTsCOD1T4Fyq+ZVJwo4S2/DK4bIuEbHLfWWgYcc BO+7MSJxfSSkqzrnOdp0WCo6jWkELE5yxRWoxVFTGiCQVGpcMH0W1SgIubZX+3A3r/Ak q1MA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jMZz9gs7; spf=pass (google.com: domain of fmdefrancesco@gmail.com designates 2a00:1450:4864:20::636 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com. [2a00:1450:4864:20::636]) by gmr-mx.google.com with ESMTPS id s141si376122wme.2.2021.04.15.13.59.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Apr 2021 13:59:06 -0700 (PDT) Received-SPF: pass (google.com: domain of fmdefrancesco@gmail.com designates 2a00:1450:4864:20::636 as permitted sender) client-ip=2a00:1450:4864:20::636; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jMZz9gs7; spf=pass (google.com: domain of fmdefrancesco@gmail.com designates 2a00:1450:4864:20::636 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: by mail-ej1-x636.google.com with SMTP id g5so32229720ejx.0 for ; Thu, 15 Apr 2021 13:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VqKz8czkX08y+e0ZGB+BKN4E0AUfG/jjvVBjvYwbxEo=; b=jMZz9gs7T0dcqwOzyzvkwp25WVb21FxR5488j9S4IMasAYzixOvsc+7S7cdby6wqbR 4o5JV77+RUfCLdY74Y3mRpcl0JRoy9xRFI4gfLy0n4MZQkYif9Yb+jF7Xzauon2Nk0QT 0LoTSBipANi90LMvCIn/Ir1IYzqLYglDkg3xJp1JSJl34xulCJzKJnEYHrCTQ9/qIoHW udFCW2Uqvipaie60nJm60NeMj35uAMW5gryuit1w+5bjJmOBOQS+7WgCHSLjCgy/O1xI v3ljN/DFle6LGTrx4+62y1g7lMLGFk/A7nyQwjp7zZUm3RvjAvWu7FVnu2iyuBi4oKUp G3Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VqKz8czkX08y+e0ZGB+BKN4E0AUfG/jjvVBjvYwbxEo=; b=TrCN4XrsSi0bjh7I2gt8Q1ZrD7/0W03bdHjRIDHwKxF8BwUkWs30IwwNFbXIq6O70W Kbm9Cngoz4R5i+NfYIEHOjDwDCgoQQuNWPk5V623ed2Lj8WVV4X9CH8uENL+akADwjIB P6aEE2Gx/Xm8RYIoBCKlCks2ZcJP+ZeNtyqIXa5mWqdcwdBQit94WZpzjJdvkWvCJlGv yqws/BtIX5mEWz4Dop+svYbjd4YwIWNaiJv6uyB8sDblvzKHyGlIcEgQdPm8OEF8c7tG vbcstEC+CYt5hN3HP26aUmZr3CeRoH2rrXq5kQELFUTP5IvV1TdIyGOkziLIbph8VXzd XYzA== X-Gm-Message-State: AOAM530VtcXUxSw1fAKNQWlhd8/Kq7ExWPRfcPF/wEzdmqJE+1dJZ8DI 9DburGynCxyqF+kJERwTaY4= X-Received: by 2002:a17:907:7745:: with SMTP id kx5mr5353769ejc.3.1618520346259; Thu, 15 Apr 2021 13:59:06 -0700 (PDT) Return-Path: Received: from linux.local (host-95-237-55-30.retail.telecomitalia.it. [95.237.55.30]) by smtp.gmail.com with ESMTPSA id h15sm2735858ejs.72.2021.04.15.13.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 13:59:05 -0700 (PDT) From: "Fabio M. De Francesco" To: Julia Lawall Cc: dri-devel@lists.freedesktop.org, outreachy-kernel@googlegroups.com, Daniel Vetter , Melissa Wen , Ben Skeggs , David Airlie Subject: Re: [Outreachy kernel] [PATCH] drm: nouveau: dispnv50: disp.c: Remove set but unused variables Date: Thu, 15 Apr 2021 22:59:04 +0200 Message-ID: <3639521.dS9dJRvPBs@linux.local> In-Reply-To: References: <20210415194423.4880-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="US-ASCII" On Thursday, April 15, 2021 9:57:07 PM CEST Julia Lawall wrote: > On Thu, 15 Apr 2021, Fabio M. De Francesco wrote: > > Removed two set but unused variables. > > Would it be useful to use the values? > It would be useful if one wants to check returns for errors (which are signaled by res different than 0). However most other drm code never checks it (as in drivers/gpu/drm/radeon/ radeon_dp_mst.c: lines 424 and 453). Differently, drivers/gpu/drm/i915/display/intel_dp_mst.c does some logging: ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); if (ret) { drm_dbg_kms(&i915->drm, "failed to update payload %d\n", ret); I could do like the second example, but I'm not sure maintainers would like it. What do you think about it? Thanks, Fabio > > julia > > > Signed-off-by: Fabio M. De Francesco > > --- > > > > drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c > > b/drivers/gpu/drm/nouveau/dispnv50/disp.c index > > 196612addfd6..828f48d5bdd4 100644 > > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > > @@ -1386,12 +1386,11 @@ nv50_mstm_cleanup(struct nv50_mstm *mstm) > > > > { > > > > struct nouveau_drm *drm = nouveau_drm(mstm->outp->base.base.dev); > > struct drm_encoder *encoder; > > > > - int ret; > > > > NV_ATOMIC(drm, "%s: mstm cleanup\n", mstm->outp->base.base.name); > > > > - ret = drm_dp_check_act_status(&mstm->mgr); > > + drm_dp_check_act_status(&mstm->mgr); > > > > - ret = drm_dp_update_payload_part2(&mstm->mgr); > > + drm_dp_update_payload_part2(&mstm->mgr); > > > > drm_for_each_encoder(encoder, mstm->outp->base.base.dev) { > > > > if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) { > > > > @@ -1410,10 +1409,9 @@ nv50_mstm_prepare(struct nv50_mstm *mstm) > > > > { > > > > struct nouveau_drm *drm = nouveau_drm(mstm->outp->base.base.dev); > > struct drm_encoder *encoder; > > > > - int ret; > > > > NV_ATOMIC(drm, "%s: mstm prepare\n", mstm->outp->base.base.name); > > > > - ret = drm_dp_update_payload_part1(&mstm->mgr); > > + drm_dp_update_payload_part1(&mstm->mgr); > > > > drm_for_each_encoder(encoder, mstm->outp->base.base.dev) { > > > > if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) { > > > > -- > > 2.31.1 > > > > -- > > You received this message because you are subscribed to the Google > > Groups "outreachy-kernel" group. To unsubscribe from this group and > > stop receiving emails from it, send an email to > > outreachy-kernel+unsubscribe@googlegroups.com. To view this discussion > > on the web visit > > https://groups.google.com/d/msgid/outreachy-kernel/20210415194423.4880 > > -1-fmdefrancesco%40gmail.com. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD7F3C433B4 for ; Thu, 15 Apr 2021 20:59:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E91561153 for ; Thu, 15 Apr 2021 20:59:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E91561153 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 041EB6EAE1; Thu, 15 Apr 2021 20:59:09 +0000 (UTC) Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by gabe.freedesktop.org (Postfix) with ESMTPS id B39B16EAE1 for ; Thu, 15 Apr 2021 20:59:07 +0000 (UTC) Received: by mail-ej1-x635.google.com with SMTP id l4so38887526ejc.10 for ; Thu, 15 Apr 2021 13:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VqKz8czkX08y+e0ZGB+BKN4E0AUfG/jjvVBjvYwbxEo=; b=jMZz9gs7T0dcqwOzyzvkwp25WVb21FxR5488j9S4IMasAYzixOvsc+7S7cdby6wqbR 4o5JV77+RUfCLdY74Y3mRpcl0JRoy9xRFI4gfLy0n4MZQkYif9Yb+jF7Xzauon2Nk0QT 0LoTSBipANi90LMvCIn/Ir1IYzqLYglDkg3xJp1JSJl34xulCJzKJnEYHrCTQ9/qIoHW udFCW2Uqvipaie60nJm60NeMj35uAMW5gryuit1w+5bjJmOBOQS+7WgCHSLjCgy/O1xI v3ljN/DFle6LGTrx4+62y1g7lMLGFk/A7nyQwjp7zZUm3RvjAvWu7FVnu2iyuBi4oKUp G3Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VqKz8czkX08y+e0ZGB+BKN4E0AUfG/jjvVBjvYwbxEo=; b=HxPTcbcwx4QfdVlMaKJJZQywxyS/TlFs/2Xaxes106NAeNQ27v5tXEtqQ6sw8dZa6t VUsaC+N5rHNLA7ax+y4XwI370gpTaGwyNDQnlbC5eJ1pkIRFzR/UibRf3NVeyNmpHsoq hP0fcKJ09JpXz0zhApmLrXZkXlp0g50rHEWIK/WWv14kGXK5SfDqkRppd+J9qch7dPsU i38gShYr04SP0XFPYCnRex/x3dsDCPsDnXmyGfPDZT56lWvSqF5UUifyNWJ4DNtM+V5A /Bdoq8yCyzPAv6PlUv7lKXMYrLJB1JTm3Dami0+LIUlPfZkJJBmyUSF9imTCRTURoPv2 aBiQ== X-Gm-Message-State: AOAM533vcSylOe0DViIFjPtvW7SrBE2pIjRH0Vw0er/uxYd2r9dUhJIT OIHrufRRrsnb8bO+Jk7+zpw= X-Google-Smtp-Source: ABdhPJwwWBS7OiWmrlt85gxxhTtBMyP3ZqTv9+mRKh+xkbN5/yo4Xi4MBrei4GGl2Po6lgfdHakGMw== X-Received: by 2002:a17:907:7745:: with SMTP id kx5mr5353769ejc.3.1618520346259; Thu, 15 Apr 2021 13:59:06 -0700 (PDT) Received: from linux.local (host-95-237-55-30.retail.telecomitalia.it. [95.237.55.30]) by smtp.gmail.com with ESMTPSA id h15sm2735858ejs.72.2021.04.15.13.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 13:59:05 -0700 (PDT) From: "Fabio M. De Francesco" To: Julia Lawall Subject: Re: [Outreachy kernel] [PATCH] drm: nouveau: dispnv50: disp.c: Remove set but unused variables Date: Thu, 15 Apr 2021 22:59:04 +0200 Message-ID: <3639521.dS9dJRvPBs@linux.local> In-Reply-To: References: <20210415194423.4880-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Melissa Wen , outreachy-kernel@googlegroups.com, Ben Skeggs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thursday, April 15, 2021 9:57:07 PM CEST Julia Lawall wrote: > On Thu, 15 Apr 2021, Fabio M. De Francesco wrote: > > Removed two set but unused variables. > > Would it be useful to use the values? > It would be useful if one wants to check returns for errors (which are signaled by res different than 0). However most other drm code never checks it (as in drivers/gpu/drm/radeon/ radeon_dp_mst.c: lines 424 and 453). Differently, drivers/gpu/drm/i915/display/intel_dp_mst.c does some logging: ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); if (ret) { drm_dbg_kms(&i915->drm, "failed to update payload %d\n", ret); I could do like the second example, but I'm not sure maintainers would like it. What do you think about it? Thanks, Fabio > > julia > > > Signed-off-by: Fabio M. De Francesco > > --- > > > > drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c > > b/drivers/gpu/drm/nouveau/dispnv50/disp.c index > > 196612addfd6..828f48d5bdd4 100644 > > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > > @@ -1386,12 +1386,11 @@ nv50_mstm_cleanup(struct nv50_mstm *mstm) > > > > { > > > > struct nouveau_drm *drm = nouveau_drm(mstm->outp->base.base.dev); > > struct drm_encoder *encoder; > > > > - int ret; > > > > NV_ATOMIC(drm, "%s: mstm cleanup\n", mstm->outp->base.base.name); > > > > - ret = drm_dp_check_act_status(&mstm->mgr); > > + drm_dp_check_act_status(&mstm->mgr); > > > > - ret = drm_dp_update_payload_part2(&mstm->mgr); > > + drm_dp_update_payload_part2(&mstm->mgr); > > > > drm_for_each_encoder(encoder, mstm->outp->base.base.dev) { > > > > if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) { > > > > @@ -1410,10 +1409,9 @@ nv50_mstm_prepare(struct nv50_mstm *mstm) > > > > { > > > > struct nouveau_drm *drm = nouveau_drm(mstm->outp->base.base.dev); > > struct drm_encoder *encoder; > > > > - int ret; > > > > NV_ATOMIC(drm, "%s: mstm prepare\n", mstm->outp->base.base.name); > > > > - ret = drm_dp_update_payload_part1(&mstm->mgr); > > + drm_dp_update_payload_part1(&mstm->mgr); > > > > drm_for_each_encoder(encoder, mstm->outp->base.base.dev) { > > > > if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) { > > > > -- > > 2.31.1 > > > > -- > > You received this message because you are subscribed to the Google > > Groups "outreachy-kernel" group. To unsubscribe from this group and > > stop receiving emails from it, send an email to > > outreachy-kernel+unsubscribe@googlegroups.com. To view this discussion > > on the web visit > > https://groups.google.com/d/msgid/outreachy-kernel/20210415194423.4880 > > -1-fmdefrancesco%40gmail.com. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel