All of lore.kernel.org
 help / color / mirror / Atom feed
From: tcremel at alphabot.fr <tcremel@alphabot.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] bug in ubifs
Date: Fri, 29 Jan 2010 14:58:19 +0100	[thread overview]
Message-ID: <36396.1264773499@alphabot.fr> (raw)

 Some bugs I found while using uboot.
 -------------------------------------------------------
  BODY { font-family:Arial, Helvetica, sans-serif;font-size:12px; }in
common/cmd_ubifs.c     from line  59 add 2 lines
           ubifs_initialized = 1;
       }
 +     // tcremel at alphabot.fr : ubifs_mounted is never reset if the
previous mount failed. This bring my system to hang as it tries to
unmount a non-existing mount point  
 +     ubifs_mounted = 0;
       ret = ubifs_mount(vol_name);
       if (ret)
           return -1;
 -------------------------------------------------------
  BODY { font-family:Arial, Helvetica, sans-serif;font-size:12px; }in
fs/ubifs/super.c   from line 1189 add 2 lines
       ret = ubifs_get_sb(&ubifs_fs_type, flags, name, data, mnt);
       if (ret) {
           printf("Error reading superblock on volume '%s'!n", name);
 + // tcremel at alphabot.fr :  added as if the filesystem does not
exist, the previous system is partly kept.  This bring my system to
hang as it has some superblocks informations from another FS
 +         ubifs_sb=NULL;
           return -1;
       }
 -------------------------------------------------------
 in BODY { font-family:Arial, Helvetica, sans-serif;font-size:12px;
}fs/ubifs/ubifs.c   from line 42 modified 1 line to 5
                  unsigned char *out, size_t *out_len)
   {
       unsigned long len = in_len;
 !     return zunzip(out, *out_len, (unsigned char *)in, &len, 0, 0);
   }
   /* Fake description object for the "none" compressor */
 >>>>>>>>>>>>>>>>>
                  unsigned char *out, size_t *out_len)
   {
       unsigned long len = in_len;
 ! // tcremel at alphabot.fr : the return length should not be lost.
 !     int res;
 !     res=zunzip(out, *out_len, (unsigned char *)in, &len, 0, 0);
 !     *out_len=len;
 !     return res;
   }
 -------------------------------------------------------
 Hope this helps ! :)
http://www.alphabot.fr

             reply	other threads:[~2010-01-29 13:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-29 13:58 tcremel at alphabot.fr [this message]
2010-01-29 14:12 ` [U-Boot] bug in ubifs Stefan Roese
2010-03-20 23:03 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36396.1264773499@alphabot.fr \
    --to=tcremel@alphabot.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.