Re: Bug#531950: attr: FTBFS on GNU/kFreeBSD

From: Nathan Scott <nscott@aconex.com>
To: Christoph Hellwig <hch@infradead.org>,
	Petr Salinger <Petr.Salinger@seznam.cz>,
	agruen@suse.de
Cc: xfs@oss.sgi.com
Subject: Re: Bug#531950: attr: FTBFS on GNU/kFreeBSD
Date: Tue, 9 Jun 2009 20:31:33 +1000 (EST)	[thread overview]
Message-ID: <364917872.6081221244543493694.JavaMail.root@mail-au.aconex.com> (raw)
In-Reply-To: <1450746396.6081061244543230576.JavaMail.root@mail-au.aconex.com>

----- "Christoph Hellwig" <hch@infradead.org> wrote:

> On Tue, Jun 09, 2009 at 10:03:28AM +1000, Nathan Scott wrote:
> > Could someone verify and merge this patch?  It looks OK to
> > me.
> 
> Andreas now takes care ot attr.  Btw, the submitter should stop that
> stupid GNU wanking - errnos are defined by the kernel so it's a
> FreeBSD issues and has nothing to do with their glibc abuse.

Hmm, I'm not sure what you mean there.  AIUI, this code
(strerror_ea) is working around Linux's lack of an ENOATTR
error code ... and on FreeBSD there really is an ENOATTR
(and no ENODATA?)  Perhaps a better fix in this case may be
to map strerror_ea directly to strerror for all platforms
except Linux?

  const char *strerror_ea(int err)
  {
-       if (err == ENODATA)
+       if (err == ENOATTR)
                 return _("No such attribute");
         return strerror(err);
  }

BTW, which git tree is the canonical acl/attr tree now Andreas?
Is it one of the kernel.org ones (which path?)?  thanks.

cheers.

-- 
Nathan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs