Re: [PATCH] check-symbol-change: fix regex to match on end of map file

[Thomas Monjalon <thomas@monjalon.net>]

01/11/2018 14:54, Neil Horman:
> the regex to determine the end of the map file chunk in a patch seems to
> be wrong,  It was using perl regex syntax, which awk doesn't appear to
> support (I'm still not sure how it was working previously).  Regardless,
> it wasn't triggering and as a result symbols were getting added to the
> mapdb that shouldn't be there.
> 
> Fix it by converting the regex to use traditional posix syntax, matching
> only on the negation of the character class [^map]
> 
> Tested and shown to be working on the ip_frag patch set provided by
> doucette@bu.edu
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: thomas@monjalon.net
> CC: doucette@bu.edu
> Reported-by: doucette@bu.edu

You could use these lines:

Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")

Reported-by: Cody Doucette <doucette@bu.edu>

> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> -		/[-+] a\/.*\.^(map)/ {in_map=0}
> +		/[-+] a\/.*\.[^map]/ {in_map=0}

Not sure this is what you intend:
[^map] means any character except "m", "a" and "p".

I don't know whether awk supports this syntax: (?!foo)