diff for duplicates of <3656925.3GuTRhx1fV@avalon> diff --git a/a/1.txt b/N1/1.txt index f6ea78b..e1f35bc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -31,8 +31,7 @@ rework changing the PINMUX_TYPE_NONE value would catch this. > 1 file changed, 19 insertions(+), 13 deletions(-) > > Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pinctrl.c -> =================================================================== -> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pinctrl.c +> =================================> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pinctrl.c > +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pinctrl.c > @@ -571,33 +571,39 @@ static const struct pinconf_ops sh_pfc_p > /* PFC ranges -> pinctrl pin descs */ @@ -52,7 +51,7 @@ the coding style of the file ? > + i < pfc->info->nr_pins; i++, info++) { > + if (info->enum_id || info->configs) -Why do you need to test info->configs as well ? I thought enum_id == 0 is +Why do you need to test info->configs as well ? I thought enum_id = 0 is always reserved, am I getting it wrong ? > + n++; @@ -106,7 +105,7 @@ multiple lines. Same comment for the counter loop above. > + pmx->pctl_desc.npins = ret; > > pmx->pctl = pinctrl_register(&pmx->pctl_desc, pfc->dev, pmx); -> if (pmx->pctl == NULL) +> if (pmx->pctl = NULL) Shouldn't you also fix sh_pfc_init_ranges() ? It includes the following code that doesn't seem to handle holes properly. diff --git a/a/content_digest b/N1/content_digest index 4b56af4..d9d1ddd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01528110.Mb5xiNU0rc@wasted.cogentembedded.com\0" "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCH] sh-pfc: handle pin array holes in sh_pfc_map_pins()\0" - "Date\0Tue, 03 Mar 2015 02:24:18 +0200\0" + "Date\0Tue, 03 Mar 2015 00:24:18 +0000\0" "To\0Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>\0" "Cc\0linus.walleij@linaro.org" linux-sh@vger.kernel.org @@ -41,8 +41,7 @@ "> 1 file changed, 19 insertions(+), 13 deletions(-)\n" "> \n" "> Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pinctrl.c\n" - "> ===================================================================\n" - "> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pinctrl.c\n" + "> =================================> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pinctrl.c\n" "> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pinctrl.c\n" "> @@ -571,33 +571,39 @@ static const struct pinconf_ops sh_pfc_p\n" "> /* PFC ranges -> pinctrl pin descs */\n" @@ -62,7 +61,7 @@ "> +\t i < pfc->info->nr_pins; i++, info++) {\n" "> +\t\tif (info->enum_id || info->configs)\n" "\n" - "Why do you need to test info->configs as well ? I thought enum_id == 0 is \n" + "Why do you need to test info->configs as well ? I thought enum_id = 0 is \n" "always reserved, am I getting it wrong ?\n" "\n" "> +\t\t\tn++;\n" @@ -116,7 +115,7 @@ "> +\tpmx->pctl_desc.npins = ret;\n" "> \n" "> \tpmx->pctl = pinctrl_register(&pmx->pctl_desc, pfc->dev, pmx);\n" - "> \tif (pmx->pctl == NULL)\n" + "> \tif (pmx->pctl = NULL)\n" "\n" "Shouldn't you also fix sh_pfc_init_ranges() ? It includes the following code \n" "that doesn't seem to handle holes properly.\n" @@ -134,4 +133,4 @@ "\n" Laurent Pinchart -ac8f5ee582b6e6337bcf5cf32243ca21dd42401756482d2eab22f681970ccff8 +f77f6f2c4e1f7da697b6881fefa0974b725776186914c3ddf15d2e719054b7a9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.