From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ujmzv-0007sm-64 for qemu-devel@nongnu.org; Tue, 04 Jun 2013 04:53:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ujmzs-0008GP-MK for qemu-devel@nongnu.org; Tue, 04 Jun 2013 04:53:43 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:47430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ujmzs-0008EI-D3 for qemu-devel@nongnu.org; Tue, 04 Jun 2013 04:53:40 -0400 Date: Tue, 4 Jun 2013 04:53:36 -0400 (EDT) From: Andrew Jones Message-ID: <366863251.3439865.1370336016425.JavaMail.root@redhat.com> In-Reply-To: References: <1370272838-15373-1-git-send-email-drjones@redhat.com> <51AD9226.4010900@linux.vnet.ibm.com> <392488894.3387176.1370331261300.JavaMail.root@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] e1000: cleanup process_tx_desc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: aliguori@us.ibm.com, mst@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, Jesse Larrew , stefanha@redhat.com, pbonzini@redhat.com ----- Original Message ----- > On 4 June 2013 08:34, Andrew Jones wrote: > > I could send a v2 that fixes the 1 error and 2 warnings found in the > > context > > of this patch, but why? It's out of the scope of the patch (although I did > > use "cleanup" in the summary...), and it would hardly make a dent in this > > file's problems. > > The idea is that we gradually bring the code closer into > line with QEMU's standards by (a) not allowing in new > code which doesn't follow the rules and (b) fixing old > code where it is in areas which a patch touches. This > gradually ratchets up the quality overall without being > huge "touch every line in a file" patches (which reduce > the functionality of git blame, among other things). > > It really isn't a very onerous requirement in my opinion. > OK, I surrender. v2 sent. Now we just need to find some bugs in the other 180 style-violating lines in order to finish cleaning up this file :-) drew > thanks > -- PMM >