From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation Date: Mon, 20 Jun 2016 16:50:01 +0200 Message-ID: <3671744.A3ustGCdmM@wuerfel> References: <20160617154737.633440-1-arnd@arndb.de> <76a47d73-26e2-5a9f-7a03-21c72ca613ca@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <76a47d73-26e2-5a9f-7a03-21c72ca613ca@sandisk.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: Bart Van Assche Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Vasu Dev , y2038@lists.linaro.org, linux-kernel@vger.kernel.org, fcoe-devel@open-fcoe.org List-Id: linux-scsi@vger.kernel.org T24gTW9uZGF5LCBKdW5lIDIwLCAyMDE2IDM6NTQ6MDYgUE0gQ0VTVCBCYXJ0IFZhbiBBc3NjaGUg d3JvdGU6Cj4gT24gMDYvMTcvMjAxNiAwNTo0NyBQTSwgQXJuZCBCZXJnbWFubiB3cm90ZToKPiA+ IC0gICAgIGppZmZpZXNfdG9fdGltZXNwZWMoamlmZmllcywgJnYwKTsKPiA+IC0gICAgIGppZmZp ZXNfdG9fdGltZXNwZWMobHBvcnQtPmJvb3RfdGltZSwgJnYxKTsKPiA+IC0gICAgIGZjX3N0YXRz LT5zZWNvbmRzX3NpbmNlX2xhc3RfcmVzZXQgPSAodjAudHZfc2VjIC0gdjEudHZfc2VjKTsKPiA+ ICsgICAgIGZjX3N0YXRzLT5zZWNvbmRzX3NpbmNlX2xhc3RfcmVzZXQgPSAobHBvcnQtPmJvb3Rf dGltZSAtIGppZmZpZXMpIC8gSFo7Cj4gCj4gRG9lcyB0aGlzIHBhdGNoIGludHJvZHVjZSBhIDY0 LWJpdCBkaXZpc2lvbj8gVGhlcmUgbWlnaHQgc3RpbGwgYmUgMzItYml0IAo+IHVzZXJzIG9mIHRo aXMgY29kZS4KCk5vLCBib3RoIGxwb3J0LT5ib290X3RpbWUgYW5kIGppZmZpZXMgYXJlICd1bnNp Z25lZCBsb25nJy4KCglBcm5kCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fClkyMDM4IG1haWxpbmcgbGlzdApZMjAzOEBsaXN0cy5saW5hcm8ub3JnCmh0dHBz Oi8vbGlzdHMubGluYXJvLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3kyMDM4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755355AbcFTOs5 (ORCPT ); Mon, 20 Jun 2016 10:48:57 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:59762 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755301AbcFTOsU (ORCPT ); Mon, 20 Jun 2016 10:48:20 -0400 From: Arnd Bergmann To: Bart Van Assche Cc: Vasu Dev , "James E.J. Bottomley" , "Martin K. Petersen" , y2038@lists.linaro.org, fcoe-devel@open-fcoe.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation Date: Mon, 20 Jun 2016 16:50:01 +0200 Message-ID: <3671744.A3ustGCdmM@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <76a47d73-26e2-5a9f-7a03-21c72ca613ca@sandisk.com> References: <20160617154737.633440-1-arnd@arndb.de> <76a47d73-26e2-5a9f-7a03-21c72ca613ca@sandisk.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:tWqSOv6GnPoamncsSU5+NkeSaps5z9w7Aa1k8jzc/nRM+e01Beg vVUuglTcS9BV+0t2LX/mGV9qEanvg6rgbc5l+qgGuiEEcUnx5mMeJZGKbUXTleWgjLNz7+E w0z8BA9dYbqEF69aXTHU9XX/JytkmiKfgSGD7DxbsA5PmxGJgOsbdNF+Tr3jB64+fjQkkVB aBuyfEBBfPsNr+uwicDxw== X-UI-Out-Filterresults: notjunk:1;V01:K0:pzkvblD1h3s=:EYIwn6RTq60q3vePkR+P2R fSJT77EdvYpQpTQeEyPW/3F81YiLiY6HCIqF13Z1zt4yj2t1kY1+DtuXis55HjDfgowXqGXe7 zI8mbRY/bwzhO3PwUyECRcki3QYfTsNR7C+ClqUfTgmirAl3tz9GdJVzitZDV2j+LTdz7J4R4 /P4BBGMV0SwRh01y8lssUzSCRKNUMyAnXayJ2LrJl3/VyKZrBXUHpEWw6nDJqWYM315stw+Nv jTn1FqhGYYlOkQ5fmPTCgpF8X7MkP78MUvdlp9y+QdxHEslhN4Bo5HC5nwwsJtKl3gKWobQam yKKCif1hfB8fERioThGbzmhwVpDu8uRk9L+zT0ia9uFqP73EkFQnN/p4pG0GrJo8rkdUhW6K8 eoMOWjMmWVIPzk5wl8o3SIoRVAKyUYOEUTdxnGenPTKEVsCmRRoUmnUOzkUoLOsM4OI1EGElQ OKgtE0oIUIdrsD49worWuIbUKZa1TnzEj3IgvvjKHjPeFNErpRNARFFVeyzzxrHmACwygzy/U wrmjAaP55kVae3sXsvCybPyjaj9gUJH/1S/VnB5QXV0Nl+5gDffVe90OS5ohOpkqyvAMDNMpY ZmUxiR89CdLbObOH+KRPOjJrdS1RAWMHjdHpcoW6mEFAX1F3CMLQPDQmCHP922uzXn3VR2irk HK8YCLbFcGEDehRSE91VLYYetmHSqFvvwQYTslZs7FIF6uAoVmdvN9skPqutlDWAMBZgNTI2q MnGKWcL+SHkvv4Sw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, June 20, 2016 3:54:06 PM CEST Bart Van Assche wrote: > On 06/17/2016 05:47 PM, Arnd Bergmann wrote: > > - jiffies_to_timespec(jiffies, &v0); > > - jiffies_to_timespec(lport->boot_time, &v1); > > - fc_stats->seconds_since_last_reset = (v0.tv_sec - v1.tv_sec); > > + fc_stats->seconds_since_last_reset = (lport->boot_time - jiffies) / HZ; > > Does this patch introduce a 64-bit division? There might still be 32-bit > users of this code. No, both lport->boot_time and jiffies are 'unsigned long'. Arnd