Re: [PATCH] common/mlx5: fix redundant field in MR control structure

[Thomas Monjalon <thomas@monjalon.net>]

16/11/2021 15:36, michaelba@nvidia.com:
> From: Michael Baum <michaelba@nvidia.com>
> 
> Inside the MR control structure there is a pointer to the common device.
> This pointer enables access to the global cache as well as hardware
> objects that may be required in case a new MR needs to be created.
> 
> The purpose of adding this pointer into the MR control structure was to
> avoid its transfer as a parameter to all the functions of searching MR
> in the caches.
> However, adding it to this structure increased the Rx and Tx data-path
> structures, all the fields that followed it were slightly moved away
> which caused to a reduction in performance.
> 
> This patch removes the pointer from the structure. It can be accessed
> through the "dev_gen_ptr" existing field using the "container_of"
> operator.
> 
> Fixes: 334ed198ab4d ("common/mlx5: remove redundant parameter in MR search")
> 
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  drivers/common/mlx5/mlx5_common_mr.c    | 42 +++++++++++++------------
>  drivers/common/mlx5/mlx5_common_mr.h    |  8 ++---
>  drivers/compress/mlx5/mlx5_compress.c   |  2 +-
>  drivers/crypto/mlx5/mlx5_crypto.c       |  2 +-
>  drivers/net/mlx5/mlx5_rx.h              | 13 ++------
>  drivers/net/mlx5/mlx5_rxq.c             |  3 +-
>  drivers/net/mlx5/mlx5_txq.c             |  3 +-
>  drivers/regex/mlx5/mlx5_regex_control.c |  3 +-
>  8 files changed, 36 insertions(+), 40 deletions(-)

Applied, thanks.