From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 055EECF9C6B for ; Tue, 24 Sep 2024 06:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I/WnZMcw14BW9YwDklsmclg05ETNmWrsUQNb71RS7HA=; b=cISmTwxdtbpEqu 52bqT4hMoHnac6AYwCSFdBJ6XWhrkVfLTC15otkb/J8eoaYCKpR5XcKZOXgQlcvclAv1sBNpdzWhq 8xC1VUX+sGe3WTahNghl34arYoMbxRFw57/hwxEWvEJzjHjsgNnTY3N/rQu/yOKhTJ09bf2FPaFPZ 6fJrPnKcB0pF8nu1qAN1fOsXHzH8Du1piZivXqgHYqiDDvp+dMnLYmJi1FUoMz1ymkWVDBH/8AOTY hf6uESIeQ5m/HODy4/VkVWCP5Qy+dkqzIM7KU+tcaPkZUXmjS42+26rxIaP7R+mgt2xVEjYSKBUsM yZqKS5X9Y93RKGQuhQlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1ssz4y-00000001GBm-40xa; Tue, 24 Sep 2024 06:31:20 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1ssz0F-00000001FLU-0T8A for linux-mtd@lists.infradead.org; Tue, 24 Sep 2024 06:26:28 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3787f30d892so2946678f8f.0 for ; Mon, 23 Sep 2024 23:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727159185; x=1727763985; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gdBSLWTjDz46WnUKd/zsdS9Z+CNhvUe7k25zO7xWOHY=; b=HXcw5SdTWl8KxldIET3APuL4bJE+XIwUEylB1N7xJUqPBIcigpKSu0WRv/HsQ5YG0Z YQJknRB3JoB5Yfxf/ZBYuIGwMrgRctiMQPGiqItBHPXPlsNC5CxNURzSJvS8tMqvRBH+ 66IR75Rk5KC8lw0P7zpYnnX0nsjltQcaEFwWAL1GjkX/xeowGAI9GesgrrMzELEASd2S 1BLyE1YCB01yxr2hwF1bgKCvbzYMDRFb849xBkLM3HLDVJqJnNXAbETXIfl4tRKQHCDf Jiluqkood0Ra+6L3JvYBmsq01BkLCB7p3Q0Oy+1aBX5/bO8Z9TQuQl6x17lVt6A64bEx /i2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727159185; x=1727763985; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gdBSLWTjDz46WnUKd/zsdS9Z+CNhvUe7k25zO7xWOHY=; b=N5Gj2UezZLyHnt/WbZrEljuwFyIHwxMMGmq1r1UkaCVemsG77aYjqKapav5vZIkhAq +6DZzekk1k2S1kgf0RRdO8hmfJG20RCVJdhPeA/Xiw57Y2Bp6RiLDNq5SadBhq5r71mT PFUUvwSR7//5dXa1IR6qhusu4qAbkyOzcjkjhRDSQmZTK4n9gyl29n0k0yRH4wBwfNxx EAokuqFIJ5JrgiBYa7YNB+HjubZl0mGV3GKe3EVeQBr33jYJWF57lroEQfmuEn/tkXYn 2KQKrkosevEV7A6vUPOqrOARcJHnR75+SIPO2uMFf2nJoYk3b7Zw0hUy0kvNn6Jf8SND Neeg== X-Gm-Message-State: AOJu0Yx4oRrQXoaacc2typ7zu289l7MmOO2TAqnm71uTVLDEOJH6bQjJ i7poGJRy20d4d5ZE3iD52lzI5PTk85n3OQDrhwaEcIsGtc9ZafEdEjwCt15u6Bk= X-Google-Smtp-Source: AGHT+IH7QCoWbsnczGD/UHfDyngk5Dnq6vWWlZdr2uSQqSKGcBjiebnb2RSWlwiXS9rCJr2xUVJQxw== X-Received: by 2002:a5d:4a07:0:b0:374:af19:7992 with SMTP id ffacd0b85a97d-37a42252c42mr6407890f8f.7.1727159185161; Mon, 23 Sep 2024 23:26:25 -0700 (PDT) Received: from [192.168.0.157] ([79.115.63.20]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc2c1acasm693353f8f.32.2024.09.23.23.26.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2024 23:26:24 -0700 (PDT) Message-ID: <368cd6fb-cab1-44ad-af46-651d9323bc19@linaro.org> Date: Tue, 24 Sep 2024 07:26:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 6/6] mtd: spi-nor: add support for Macronix Octal flash To: Alvin Zhou Cc: linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, pratyush@kernel.org, mwalle@kernel.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, broonie@kernel.org, chengminglin@mxic.com.tw, leoyu@mxic.com.tw, AlvinZhou , JaimeLiao , Bough Chen References: <20240718034614.484018-1-alvinzhou.tw@gmail.com> <20240718034614.484018-7-alvinzhou.tw@gmail.com> <97134efb-398d-4c21-a915-87a5b4f1b29a@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240923_232627_181258_BD832230 X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org CgpPbiA5LzI0LzI0IDQ6MjUgQU0sIEFsdmluIFpob3Ugd3JvdGU6Cj4gSGkgVHVkb3IsCj4gCj4g VHVkb3IgQW1iYXJ1cyA8dHVkb3IuYW1iYXJ1c0BsaW5hcm8ub3JnPiDmlrwgMjAyNOW5tDnmnIgy M+aXpSDpgLHkuIAg5LiL5Y2IMjo1NOWvq+mBk++8mgo+Pgo+PiBIaSwgQWx2aW4sCj4+Cj4+IEkg cXVpY2tseSBza2ltbWVkIG92ZXIgdGhlIHByZXZpb3VzIDUgcGF0Y2hlcyBhbmQgdGhleSBhcmUg bG9va2luZyBmaW5lLgo+Pgo+PiBJIGRvbid0IGdldCB0aGlzIHBhdGNoIGhvd2V2ZXIuCj4+Cj4+ IE9uIDcvMTgvMjQgNDo0NiBBTSwgQWx2aW5aaG91IHdyb3RlOgo+Pj4gRnJvbTogQWx2aW5aaG91 IDxhbHZpbnpob3VAbXhpYy5jb20udHc+Cj4+Pgo+Pj4gQWRkaW5nIE1hbnVmYWN0dXJlIElEIDB4 QzIgaW4gbGFzdCBvZiBJRCB0YWJsZSBiZWNhdXNlIG9mCj4+PiBPY3RhbCBGbGFzaCBuZWVkIG1h bnVmYWN0dXJlciBmaXh1cCBmb3IgZW5hYmxpbmcvZGlzYWJsaW5nCj4+PiBPY3RhbCBEVFIgbW9k ZS4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBKYWltZUxpYW8gPGphaW1lbGlhb0BteGljLmNvbS50 dz4KPj4+IFNpZ25lZC1vZmYtYnk6IEFsdmluWmhvdSA8YWx2aW56aG91QG14aWMuY29tLnR3Pgo+ Pj4gLS0tCj4+PiAgZHJpdmVycy9tdGQvc3BpLW5vci9tYWNyb25peC5jIHwgNCArKystCj4+PiAg MSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Pj4KPj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL210ZC9zcGktbm9yL21hY3Jvbml4LmMgYi9kcml2ZXJzL210ZC9z cGktbm9yL21hY3Jvbml4LmMKPj4+IGluZGV4IGYwMzk4MTlhNTI1Mi4uMWE4Y2NlYmRmZTBlIDEw MDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9tdGQvc3BpLW5vci9tYWNyb25peC5jCj4+PiArKysgYi9k cml2ZXJzL210ZC9zcGktbm9yL21hY3Jvbml4LmMKPj4+IEBAIC0yMDAsNyArMjAwLDkgQEAgc3Rh dGljIGNvbnN0IHN0cnVjdCBmbGFzaF9pbmZvIG1hY3Jvbml4X25vcl9wYXJ0c1tdID0gewo+Pj4g ICAgICAgICAgICAgICAubmFtZSA9ICJteDI1bDMyNTVlIiwKPj4+ICAgICAgICAgICAgICAgLnNp emUgPSBTWl80TSwKPj4+ICAgICAgICAgICAgICAgLm5vX3NmZHBfZmxhZ3MgPSBTRUNUXzRLLAo+ Pj4gLSAgICAgfQo+Pj4gKyAgICAgfSwKPj4+ICsgICAgIC8qIE5lZWQgdGhlIG1hbnVmYWN0dXJl ciBmaXh1cHMsIEtlZXAgdGhpcyBsYXN0ICovCj4+PiArICAgICB7IC5pZCA9IFNOT1JfSUQoMHhj MikgfQo+Pj4gIH07Cj4+Pgo+Pgo+PiBDb3VsZCB5b3UgcGxlYXNlIGVsYWJvcmF0ZSB3aHkgeW91 IG5lZWQganVzdCB0aGUgbWFudWZhY3R1cmVyIGlkIGhlcmU/IEkKPj4gd291bGQgaGF2ZSBleHBl Y3RlZCB0byBzZWUgYSBzcGVjaWZpYyBmbGFzaCBlbnRyeSBpbnN0ZWFkLgo+IAo+IEdyYXRlZnVs IHRvIE1pY2hhZWwgZm9yIHRoZSB2YWx1YWJsZSBzdWdnZXN0aW9uLiBUaGlzIGFkZGl0aW9uIG9m IHRoZQo+IE1hY3Jvbml4IG1hbnVmYWN0dXJlciBJRCBlbmFibGVzIHRoZSBmaXh1cCBmdW5jdGlv bnMgc3VjaCBhcwo+IG1hY3Jvbml4X25vcl9zZXRfb2N0YWxfZHRyIHRvIGJlIGV4ZWN1dGVkIHdp dGhvdXQgdGhlIG5lZWQgdG8KPiBjcmVhdGUgc2VwYXJhdGUgSUQgZW50cmllcyBmb3IgZWFjaCBP Y3RhbCBEVFIgTk9SIEZsYXNoIGluIHRoZQo+IGZsYXNoX2luZm8uCj4gCgpBaCwgbmljZS4gT2th eSB0aGVuLiBJJ20gZ29pbmcgdG8gcmV2aWV3IHRoZSByZXN0IG9mIHRoZSBwYXRjaGVzLiBUaGV5 Cmxvb2sgcHJvbWlzaW5nIDspLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05EA773451 for ; Tue, 24 Sep 2024 06:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727159189; cv=none; b=MJoxmy+oPHD2b1Oa++Mf38L4C/Q8QMXa90dk6REm/ihfFN8nS1wN4GWwlzPLJF43FPm2qZIj0t//HZZO8u4ASfPsGRnl3iSfjS6KZnMcy20eZ5XAt1q5Fe7koA45BTtFxqN8iAFN2dWnnqnJXbn1ktwxkEGzh/9q3W7zL2oj7d0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727159189; c=relaxed/simple; bh=lYTd7hQ8FAoCkKxITL4zdXuYX8Yn/AHY0EdO4ffZYAQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AaT4YLcY54MmgIxTuJKSFTKaI8fgtDEDBUWhC647eP5vrcB6JEl8npF4D4CXFekf0A46zgF62wUjq++9MpNsV1yjSqR0uBDoVfUlb9X6KhvLh0wXEWpVyRoJNzYu/OTZz7pHJbq7zuK5DGtfTIjFZlZiqoJ9UNWkC7p9NlqFgwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fQAjDCcS; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fQAjDCcS" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-374d29ad870so2834046f8f.3 for ; Mon, 23 Sep 2024 23:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727159185; x=1727763985; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gdBSLWTjDz46WnUKd/zsdS9Z+CNhvUe7k25zO7xWOHY=; b=fQAjDCcSNUTRxIM1dmv0SUvdNpT3s2gDbNVTAeaeHoLy8xwJShFrP0jkZQ4tcBZRFo O7H5y8Ovw94mhm3nbbadfwYHQUTMiSqpvIlM7Xv3NYbb18DZzZm/1+U7IhuBJgVjrGDt N2cQ3Y3MZxtoNJvAZFHgj3O9s6nheIOnpDZBTpppEFiax0cmh+NF4qfGGLNCiYTAk0Pm OJiZZnWH52zm1U3mQNVH/L1cq336WqXJubl4F7hnwxsv/jb8DfK7js+3oonIO72VM+oV sngqYuDt8XIx4v2mSOk07I/GRMPkxXwetmI0dsH7rb++ptRZvUDNGG+XvYaWRj4TdpYQ djaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727159185; x=1727763985; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gdBSLWTjDz46WnUKd/zsdS9Z+CNhvUe7k25zO7xWOHY=; b=p6CBxwZYigpAM7upCnBqr15XyOGCci9zW8k2d8Ve+moVXrljMKkSAUtN1wb77K+5Ji v5WgUBjV/S4aeTSXxzBGYHyBRo81QS6sAYzbR0xZUlTlMpsKU7DmzuvnZfN5K8okiJL+ E7TRINK/YN7IK/0YnggTODt+iZLSC1RdwggemQXgjH0rMo0jcBoGuhgIbfgsl3w5+EF6 avxKefyCM2j3XccQMPX+pRGqV/jvzBsqqF2YLXzTjgFb1yK4sJ/M7Wd6ydO8L6KGfY0a gWSmB10DQptG/4aVk6IV8bcITFuBexxtapjOvSwwxS7iqCn3Xalp0SLNNqPoN+qJHZtP T1mg== X-Forwarded-Encrypted: i=1; AJvYcCXZ/iQH6CZHG5VyXYRStQTiTL55eD7LlttTqKRQ0GUydbaKfKD9LikMp3MuX+TdMak14HzWo73z9Ok=@vger.kernel.org X-Gm-Message-State: AOJu0YwoUbaKPzIP4Ppk5mC6l3Td3gUv36nOPLBHa/EKx3Eh/c0ObM0i znMJLccl3DnfF93r03fxDhd+43T7sJhFy9givQ4z7bVu7TBYf6jdxH6H9vzHsxg= X-Google-Smtp-Source: AGHT+IH7QCoWbsnczGD/UHfDyngk5Dnq6vWWlZdr2uSQqSKGcBjiebnb2RSWlwiXS9rCJr2xUVJQxw== X-Received: by 2002:a5d:4a07:0:b0:374:af19:7992 with SMTP id ffacd0b85a97d-37a42252c42mr6407890f8f.7.1727159185161; Mon, 23 Sep 2024 23:26:25 -0700 (PDT) Received: from [192.168.0.157] ([79.115.63.20]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc2c1acasm693353f8f.32.2024.09.23.23.26.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2024 23:26:24 -0700 (PDT) Message-ID: <368cd6fb-cab1-44ad-af46-651d9323bc19@linaro.org> Date: Tue, 24 Sep 2024 07:26:22 +0100 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 6/6] mtd: spi-nor: add support for Macronix Octal flash To: Alvin Zhou Cc: linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, pratyush@kernel.org, mwalle@kernel.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, broonie@kernel.org, chengminglin@mxic.com.tw, leoyu@mxic.com.tw, AlvinZhou , JaimeLiao , Bough Chen References: <20240718034614.484018-1-alvinzhou.tw@gmail.com> <20240718034614.484018-7-alvinzhou.tw@gmail.com> <97134efb-398d-4c21-a915-87a5b4f1b29a@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 9/24/24 4:25 AM, Alvin Zhou wrote: > Hi Tudor, > > Tudor Ambarus 於 2024年9月23日 週一 下午2:54寫道： >> >> Hi, Alvin, >> >> I quickly skimmed over the previous 5 patches and they are looking fine. >> >> I don't get this patch however. >> >> On 7/18/24 4:46 AM, AlvinZhou wrote: >>> From: AlvinZhou >>> >>> Adding Manufacture ID 0xC2 in last of ID table because of >>> Octal Flash need manufacturer fixup for enabling/disabling >>> Octal DTR mode. >>> >>> Signed-off-by: JaimeLiao >>> Signed-off-by: AlvinZhou >>> --- >>> drivers/mtd/spi-nor/macronix.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c >>> index f039819a5252..1a8ccebdfe0e 100644 >>> --- a/drivers/mtd/spi-nor/macronix.c >>> +++ b/drivers/mtd/spi-nor/macronix.c >>> @@ -200,7 +200,9 @@ static const struct flash_info macronix_nor_parts[] = { >>> .name = "mx25l3255e", >>> .size = SZ_4M, >>> .no_sfdp_flags = SECT_4K, >>> - } >>> + }, >>> + /* Need the manufacturer fixups, Keep this last */ >>> + { .id = SNOR_ID(0xc2) } >>> }; >>> >> >> Could you please elaborate why you need just the manufacturer id here? I >> would have expected to see a specific flash entry instead. > > Grateful to Michael for the valuable suggestion. This addition of the > Macronix manufacturer ID enables the fixup functions such as > macronix_nor_set_octal_dtr to be executed without the need to > create separate ID entries for each Octal DTR NOR Flash in the > flash_info. > Ah, nice. Okay then. I'm going to review the rest of the patches. They look promising ;).