From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:37586 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759079AbeD0VeM (ORCPT ); Fri, 27 Apr 2018 17:34:12 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , open list Subject: Re: [PATCH v2 10/11] arm64: dts: r8a77965-salvator-x: Enable DU external clocks and HDMI Date: Sat, 28 Apr 2018 00:34:26 +0300 Message-ID: <3691864.jEUybrQDu7@avalon> In-Reply-To: <20180427165722.19445-11-kieran.bingham+renesas@ideasonboard.com> References: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com> <20180427165722.19445-11-kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Friday, 27 April 2018 19:57:21 EEST Kieran Bingham wrote: > The DU1 external dot clock is provided by the fixed frequency clock > generator X21, while the DU0 and DU3 clocks are provided by the > programmable Versaclock5 clock generator. > > Enable the clocks, and the HDMI encoder for the M3-N Salvator-X board > and hook it up to the HDMI connector. > > Based on patches from Takeshi Kihara > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart > --- > v2: > - Remove LVDS clocks from DU node > - Merge DU Clocks and HDMI enablement > --- > .../boot/dts/renesas/r8a77965-salvator-x.dts | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts > b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts index > 75d890d91df9..340a3c72b65a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts > @@ -19,3 +19,31 @@ > reg = <0x0 0x48000000 0x0 0x78000000>; > }; > }; > + > +&du { > + clocks = <&cpg CPG_MOD 724>, > + <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 721>, > + <&versaclock5 1>, > + <&x21_clk>, > + <&versaclock5 2>; > + clock-names = "du.0", "du.1", "du.3", > + "dclkin.0", "dclkin.1", "dclkin.3"; > +}; > + > +&hdmi0 { > + status = "okay"; > + > + ports { > + port@1 { > + reg = <1>; > + rcar_dw_hdmi0_out: endpoint { > + remote-endpoint = <&hdmi0_con>; > + }; > + }; > + }; > +}; > + > +&hdmi0_con { > + remote-endpoint = <&rcar_dw_hdmi0_out>; > +}; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Sat, 28 Apr 2018 00:34:26 +0300 Subject: [PATCH v2 10/11] arm64: dts: r8a77965-salvator-x: Enable DU external clocks and HDMI In-Reply-To: <20180427165722.19445-11-kieran.bingham+renesas@ideasonboard.com> References: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com> <20180427165722.19445-11-kieran.bingham+renesas@ideasonboard.com> Message-ID: <3691864.jEUybrQDu7@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Kieran, Thank you for the patch. On Friday, 27 April 2018 19:57:21 EEST Kieran Bingham wrote: > The DU1 external dot clock is provided by the fixed frequency clock > generator X21, while the DU0 and DU3 clocks are provided by the > programmable Versaclock5 clock generator. > > Enable the clocks, and the HDMI encoder for the M3-N Salvator-X board > and hook it up to the HDMI connector. > > Based on patches from Takeshi Kihara > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart > --- > v2: > - Remove LVDS clocks from DU node > - Merge DU Clocks and HDMI enablement > --- > .../boot/dts/renesas/r8a77965-salvator-x.dts | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts > b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts index > 75d890d91df9..340a3c72b65a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts > @@ -19,3 +19,31 @@ > reg = <0x0 0x48000000 0x0 0x78000000>; > }; > }; > + > +&du { > + clocks = <&cpg CPG_MOD 724>, > + <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 721>, > + <&versaclock5 1>, > + <&x21_clk>, > + <&versaclock5 2>; > + clock-names = "du.0", "du.1", "du.3", > + "dclkin.0", "dclkin.1", "dclkin.3"; > +}; > + > +&hdmi0 { > + status = "okay"; > + > + ports { > + port at 1 { > + reg = <1>; > + rcar_dw_hdmi0_out: endpoint { > + remote-endpoint = <&hdmi0_con>; > + }; > + }; > + }; > +}; > + > +&hdmi0_con { > + remote-endpoint = <&rcar_dw_hdmi0_out>; > +}; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 10/11] arm64: dts: r8a77965-salvator-x: Enable DU external clocks and HDMI Date: Sat, 28 Apr 2018 00:34:26 +0300 Message-ID: <3691864.jEUybrQDu7@avalon> References: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com> <20180427165722.19445-11-kieran.bingham+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180427165722.19445-11-kieran.bingham+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Simon Horman , Catalin Marinas , Magnus Damm , open list , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Rob Herring , Will Deacon , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" List-Id: devicetree@vger.kernel.org SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXksIDI3IEFwcmls IDIwMTggMTk6NTc6MjEgRUVTVCBLaWVyYW4gQmluZ2hhbSB3cm90ZToKPiBUaGUgRFUxIGV4dGVy bmFsIGRvdCBjbG9jayBpcyBwcm92aWRlZCBieSB0aGUgZml4ZWQgZnJlcXVlbmN5IGNsb2NrCj4g Z2VuZXJhdG9yIFgyMSwgd2hpbGUgdGhlIERVMCBhbmQgRFUzIGNsb2NrcyBhcmUgcHJvdmlkZWQg YnkgdGhlCj4gcHJvZ3JhbW1hYmxlIFZlcnNhY2xvY2s1IGNsb2NrIGdlbmVyYXRvci4KPiAKPiBF bmFibGUgdGhlIGNsb2NrcywgYW5kIHRoZSBIRE1JIGVuY29kZXIgZm9yIHRoZSBNMy1OIFNhbHZh dG9yLVggYm9hcmQKPiBhbmQgaG9vayBpdCB1cCB0byB0aGUgSERNSSBjb25uZWN0b3IuCj4gCj4g QmFzZWQgb24gcGF0Y2hlcyBmcm9tIFRha2VzaGkgS2loYXJhIDx0YWtlc2hpLmtpaGFyYS5kZkBy ZW5lc2FzLmNvbT4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBLaWVyYW4gQmluZ2hhbSA8a2llcmFuLmJp bmdoYW0rcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgoKUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGlu Y2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gLS0tCj4gdjI6Cj4g IC0gUmVtb3ZlIExWRFMgY2xvY2tzIGZyb20gRFUgbm9kZQo+ICAtIE1lcmdlIERVIENsb2NrcyBh bmQgSERNSSBlbmFibGVtZW50Cj4gLS0tCj4gIC4uLi9ib290L2R0cy9yZW5lc2FzL3I4YTc3OTY1 LXNhbHZhdG9yLXguZHRzICB8IDI4ICsrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5n ZWQsIDI4IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0 cy9yZW5lc2FzL3I4YTc3OTY1LXNhbHZhdG9yLXguZHRzCj4gYi9hcmNoL2FybTY0L2Jvb3QvZHRz L3JlbmVzYXMvcjhhNzc5NjUtc2FsdmF0b3IteC5kdHMgaW5kZXgKPiA3NWQ4OTBkOTFkZjkuLjM0 MGEzYzcyYjY1YSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMvcjhh Nzc5NjUtc2FsdmF0b3IteC5kdHMKPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMv cjhhNzc5NjUtc2FsdmF0b3IteC5kdHMKPiBAQCAtMTksMyArMTksMzEgQEAKPiAgCQlyZWcgPSA8 MHgwIDB4NDgwMDAwMDAgMHgwIDB4NzgwMDAwMDA+Owo+ICAJfTsKPiAgfTsKPiArCj4gKyZkdSB7 Cj4gKwljbG9ja3MgPSA8JmNwZyBDUEdfTU9EIDcyND4sCj4gKwkJIDwmY3BnIENQR19NT0QgNzIz PiwKPiArCQkgPCZjcGcgQ1BHX01PRCA3MjE+LAo+ICsJCSA8JnZlcnNhY2xvY2s1IDE+LAo+ICsJ CSA8JngyMV9jbGs+LAo+ICsJCSA8JnZlcnNhY2xvY2s1IDI+Owo+ICsJY2xvY2stbmFtZXMgPSAi ZHUuMCIsICJkdS4xIiwgImR1LjMiLAo+ICsJCSAgICAgICJkY2xraW4uMCIsICJkY2xraW4uMSIs ICJkY2xraW4uMyI7Cj4gK307Cj4gKwo+ICsmaGRtaTAgewo+ICsJc3RhdHVzID0gIm9rYXkiOwo+ ICsKPiArCXBvcnRzIHsKPiArCQlwb3J0QDEgewo+ICsJCQlyZWcgPSA8MT47Cj4gKwkJCXJjYXJf ZHdfaGRtaTBfb3V0OiBlbmRwb2ludCB7Cj4gKwkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JmhkbWkw X2Nvbj47Cj4gKwkJCX07Cj4gKwkJfTsKPiArCX07Cj4gK307Cj4gKwo+ICsmaGRtaTBfY29uIHsK PiArCXJlbW90ZS1lbmRwb2ludCA9IDwmcmNhcl9kd19oZG1pMF9vdXQ+Owo+ICt9OwoKLS0gClJl Z2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=