From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] examples/l3fwd: exact-match rework Date: Mon, 29 Feb 2016 11:45:39 +0100 Message-ID: <3693025.4xSy8mvUuT@xps13> References: <1456307324-3116-1-git-send-email-tomaszx.kulasek@intel.com> <1456741987-2196-1-git-send-email-tomaszx.kulasek@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Tomasz Kulasek Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id D47FB2C69 for ; Mon, 29 Feb 2016 11:47:16 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id p65so39519822wmp.0 for ; Mon, 29 Feb 2016 02:47:16 -0800 (PST) In-Reply-To: <1456741987-2196-1-git-send-email-tomaszx.kulasek@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-02-29 11:33, Tomasz Kulasek: > Current implementation of Exact-Match uses different execution path than > for LPM. Unifying them allows to reuse big part of LPM code and sightly > increase performance of Exact-Match. > > Main changes: > ------------- > * Packet classification stage is separated from the rest of path for both > LPM and EM. > * Packet processing, modifying and transmit part is the same for LPM and EM > and mostly based on the current LPM implementation. > * Shared code is moved to the common file "l3fwd_sse.h". > * While sequential packet classification in EM path, seems to be faster > than using multi hash lookup, used before, it is used by default. Old > implementation is moved to the file l3fwd_em_hlm_sse.h and can be enabled > with HASH_LOOKUP_MULTI global define in compilation time. > > This patch depends of Ravi Kerur's "Modify and modularize l3fwd code" and > should be applied after it. > > Changes in v3: > - fixed error: unused function 'l3fwd_em_simple_forward'. This function is > used only in l3fwd_em_no_opt_send_packets, and after moving it to new > header file l3fwd_em.h in Ravi's patch, also should be moved there. > > Changes in v2: > - patch rebase to be applicable on top of "Modify and modularize l3fwd > code" v3 > > Signed-off-by: Tomasz Kulasek > Acked-by: Konstantin Ananyev Applied, thanks