All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Xu, Yanfei" <yanfei.xu@windriver.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: export disk_part_iter_* helpers
Date: Fri, 26 Mar 2021 21:01:10 +0800	[thread overview]
Message-ID: <36934d10-bfb2-032e-813b-a514ee524853@windriver.com> (raw)
In-Reply-To: <20210326121359.GA14989@lst.de>



On 3/26/21 8:13 PM, Christoph Hellwig wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> On Fri, Mar 26, 2021 at 08:10:59PM +0800, yanfei.xu@windriver.com wrote:
>> From: Yanfei Xu <yanfei.xu@windriver.com>
>>
>> disk_part_iter_* helpers might be used by other external modules, like
>> lttng-modules. But it was unexport in 'commit bc359d03c7ec ("block: add
>> a disk_uevent helper")'. Here export them again.
> 
> Err, no.  We never export things for out of tree modules.  And any kind
> of driver code has absolutely no business looking at the partition tables
> to start with, modular or not.
> I see. Thanks.

//Yanfei

      reply	other threads:[~2021-03-26 13:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 12:10 [PATCH] block: export disk_part_iter_* helpers yanfei.xu
2021-03-26 12:13 ` Christoph Hellwig
2021-03-26 13:01   ` Xu, Yanfei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36934d10-bfb2-032e-813b-a514ee524853@windriver.com \
    --to=yanfei.xu@windriver.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.