From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, ismael.luceno@corp.bluecherry.net,
pete@sensoray.com, sylvester.nawrocki@gmail.com,
sakari.ailus@iki.fi, Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [RFCv2 PATCH 08/10] DocBook: document new v4l motion detection event.
Date: Thu, 22 Aug 2013 12:35:50 +0200 [thread overview]
Message-ID: <3694568.GamCuCjpdV@avalon> (raw)
In-Reply-To: <5215B203.5080203@xs4all.nl>
Hi Hans,
On Thursday 22 August 2013 08:38:59 Hans Verkuil wrote:
> On 08/21/2013 11:41 PM, Laurent Pinchart wrote:
> > On Monday 12 August 2013 12:58:31 Hans Verkuil wrote:
> >> From: Hans Verkuil <hans.verkuil@cisco.com>
> >>
> >> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> >> ---
> >>
> >> Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 40 ++++++++++++++++
> >> .../DocBook/media/v4l/vidioc-subscribe-event.xml | 9 +++++
> >> 2 files changed, 49 insertions(+)
[snip]
> >> diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> >> b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml index
> >> 5c70b61..d9c3e66 100644
> >> --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> >> +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> >> @@ -155,6 +155,15 @@
> >>
> >> </entry>
> >>
> >> </row>
> >> <row>
> >>
> >> + <entry><constant>V4L2_EVENT_MOTION_DET</constant></entry>
> >> + <entry>5</entry>
> >> + <entry>
> >> + <para>Triggered whenever the motion detection state changes,
i.e.
> >> + whether motion is detected or not.
> >
> > Isn't the event also triggered when region_mask changes from a non-zero
> > value to a different non-zero value ? The second part of the sentence
> > seems to imply that the even is only triggered when motion starts being
> > detected or stops being detected.
>
> Good point. How about this:
>
> "Triggered whenever the motion detection state for one or more of the
> regions changes."
That sounds good to me.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-08-22 10:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 10:58 [RFCv2 PATCH 00/10] Matrix and Motion Detection support Hans Verkuil
2013-08-12 10:58 ` [RFCv2 PATCH 01/10] v4l2-controls: add motion detection controls Hans Verkuil
2013-08-21 21:36 ` Laurent Pinchart
2013-08-22 6:32 ` Hans Verkuil
2013-08-12 10:58 ` [RFCv2 PATCH 02/10] v4l2: add matrix support Hans Verkuil
2013-08-14 14:33 ` Sakari Ailus
2013-08-15 6:35 ` Hans Verkuil
2013-08-15 8:23 ` Sakari Ailus
2013-08-12 10:58 ` [RFCv2 PATCH 03/10] v4l2-compat-ioctl32: add g/s_matrix support Hans Verkuil
2013-08-21 22:02 ` Laurent Pinchart
2013-08-22 6:41 ` Hans Verkuil
2013-08-12 10:58 ` [RFCv2 PATCH 04/10] solo: implement the new matrix ioctls instead of the custom ones Hans Verkuil
2013-08-12 10:58 ` [RFCv2 PATCH 05/10] v4l2: add a motion detection event Hans Verkuil
2013-08-12 10:58 ` [RFCv2 PATCH 06/10] solo6x10: implement motion detection events and controls Hans Verkuil
2013-08-12 10:58 ` [RFCv2 PATCH 07/10] DocBook: add the new v4l detection class controls Hans Verkuil
2013-08-12 10:58 ` [RFCv2 PATCH 08/10] DocBook: document new v4l motion detection event Hans Verkuil
2013-08-21 21:41 ` Laurent Pinchart
2013-08-22 6:38 ` Hans Verkuil
2013-08-22 10:35 ` Laurent Pinchart [this message]
2013-08-12 10:58 ` [RFCv2 PATCH 09/10] DocBook: document the new v4l2 matrix ioctls Hans Verkuil
2013-08-21 21:58 ` Laurent Pinchart
2013-08-22 6:56 ` Hans Verkuil
2013-08-22 10:34 ` Laurent Pinchart
2013-08-22 10:42 ` Hans Verkuil
2013-08-12 10:58 ` [RFCv2 PATCH 10/10] go7007: add motion detection support Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3694568.GamCuCjpdV@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=ismael.luceno@corp.bluecherry.net \
--cc=linux-media@vger.kernel.org \
--cc=pete@sensoray.com \
--cc=sakari.ailus@iki.fi \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.