All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Waite <linwoes@gmail.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND][PATCH] ppc: fix powersave with interrupts disabled
Date: Thu, 13 Jan 2005 21:36:32 -0500	[thread overview]
Message-ID: <36b714c805011318367e28ef76@mail.gmail.com> (raw)
In-Reply-To: <36b714c80501131426a91c908@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

I apologize ahead of time for my mailer corrupting the patch. Here is
the patch again attached so as to get whitespace corruption. Also, I
removed a set of excessive parens.

Signed-off-by: Brian Waite <waite@skycomputers.com>

--- 1.22/arch/ppc/kernel/idle.c Tue Jan 11 19:42:36 2005
+++ edited/arch/ppc/kernel/idle.c       Thu Jan 13 17:22:25 2005
@@ -39,8 +39,9 @@
        powersave = ppc_md.power_save;

        if (!need_resched()) {
-               if (powersave != NULL)
-                       powersave();
+               if (powersave != NULL && !irqs_disabled())
+                           powersave();
+
                else {
 #ifdef CONFIG_SMP
                        set_thread_flag(TIF_POLLING_NRFLAG);

[-- Attachment #2: powersave_idle.c.patch --]
[-- Type: application/octet-stream, Size: 433 bytes --]

===== arch/ppc/kernel/idle.c 1.22 vs edited =====
--- 1.22/arch/ppc/kernel/idle.c	Tue Jan 11 19:42:36 2005
+++ edited/arch/ppc/kernel/idle.c	Thu Jan 13 17:22:25 2005
@@ -39,8 +39,9 @@
 	powersave = ppc_md.power_save;
 
 	if (!need_resched()) {
-		if (powersave != NULL)
-			powersave();
+		if (powersave != NULL && !irqs_disabled())
+			    powersave();
+			    
 		else {
 #ifdef CONFIG_SMP
 			set_thread_flag(TIF_POLLING_NRFLAG);

      reply	other threads:[~2005-01-14  2:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200501120407.j0C477s1019067@hera.kernel.org>
2005-01-13 20:58 ` [PATCH] ppc: fix idle with interrupts disabled Brian Waite
2005-01-13 22:26   ` [PATCH] ppc: fix powersave " Brian Waite
2005-01-14  2:36     ` Brian Waite [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36b714c805011318367e28ef76@mail.gmail.com \
    --to=linwoes@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.