From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35CF6C46467 for ; Tue, 3 Jan 2023 15:58:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E25C98548B; Tue, 3 Jan 2023 16:57:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1672761479; bh=k+TrDWFFcmhlW1+GaS68xbJK7WOmuqkIYx0ABx3I5dQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XY4DcHpbVevrqutUmFUYN3gBw1a0dtAINovzCFb3tzMDjxU8vJuLycNi7XKntkAy3 LEoo9QfW49VWb4gz+5lSlKbPi1WixCTFLwaihyxsrHPF9+WoXfolYHTZrmSKdQMciE z6YShNbrhAhdSscUN6GYLhFDdOTGhrgqnVil72hBW96srKUhR9z/M6ed+FQ2e7rlPy kAMvZmgMCPaK5IQijDGBznJiiBHYT3dPweOFdhj6Jn+8h8eIK+MOo2DpU/aCtmVTb7 9NAEplNNyX73mgVilBphmBXKnvzm2beHO3UjpZa/CJZwlxCa7srXxf5zJZYPhtMUEx Scp7G63draXMA== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 60E2B85548; Tue, 3 Jan 2023 16:57:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1672761477; bh=k+TrDWFFcmhlW1+GaS68xbJK7WOmuqkIYx0ABx3I5dQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dp/sh40xmKI8tX5+71wEJg3KiD8aKd3XVWRseatxe75Es16vNS8A8vmEi1cUA1taq JPrFivjzkv4gLHUW8eAu39pDFWFLfRQVSY+haRl9ZVIlIGnQLGdWuHK+joFKUKrMgE f9dihoEAV5YeWHBtkQ4mTnQMwwNISYoN9AUoXaMc9Y1aKDaxR8vJcSKU7LFH8/mQbI 3lDo/sEh0eTLwDIQB0Pi1lpxhpDssV3H8x7rc339Mjq/QxAlA/O0VHCuCxCOVzXqbw sGw/Rl7rYrZ7q6pi2eKdSx4J8WkzbZtE4TPvu4grHOJ/Fxj9EhKQStAvTV3FZI/mjN yo0x5Mx7ZRNoA== Message-ID: <36beada3-02ff-f33f-dc4e-517ccbc8cdf3@denx.de> Date: Tue, 3 Jan 2023 16:57:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/4] usb: ohci-at91: Enable OHCI functionality and register into DM Content-Language: en-US To: Sergiu.Moga@microchip.com, michal.simek@amd.com, jim.t90615@gmail.com, sumit.garg@linaro.org, weijie.gao@mediatek.com, sjg@chromium.org, Eugen.Hristev@microchip.com, Cristian.Birsan@microchip.com Cc: u-boot@lists.denx.de References: <20221223123454.362757-1-sergiu.moga@microchip.com> <20221223123454.362757-3-sergiu.moga@microchip.com> <83364386-7f6f-af67-7108-4d04fcd096d9@denx.de> <0c5b3222-4df4-eea1-8568-5cd6ccea3962@denx.de> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/3/23 16:49, Sergiu.Moga@microchip.com wrote: > On 03.01.2023 16:34, Marek Vasut wrote: >> On 1/3/23 13:11, Sergiu.Moga@microchip.com wrote: >>> On 03.01.2023 01:26, Marek Vasut wrote: >>>> On 12/23/22 13:34, Sergiu Moga wrote: >>>> >>>> [...] >>>> >>>>> diff --git a/drivers/usb/host/ohci-at91.c >>>>> b/drivers/usb/host/ohci-at91.c >>>>> index 9b955c1bd6..9ae55c6e5d 100644 >>>>> --- a/drivers/usb/host/ohci-at91.c >>>>> +++ b/drivers/usb/host/ohci-at91.c >>>>> @@ -5,6 +5,9 @@ >>>>>     */ >>>>> >>>>>    #include >>>>> + >>>>> +#if !(CONFIG_IS_ENABLED(DM_USB)) >>>>> + >>>>>    #include >>>>> >>>>>    int usb_cpu_init(void) >>>>> @@ -62,3 +65,183 @@ int usb_cpu_init_fail(void) >>>>>    { >>>>>        return usb_cpu_stop(); >>>>>    } >>>> >>>> Would it be possible to just remove the non-DM functionality ? >>>> >>> >>> Unfortunately, the other older boards would not build and work anymore >>> if I were to remove this. >> >> Any chance they can be converted to DM ? >> > > Not at the moment, no. Why ?