From: Nicolai Buchwitz <nb@tipi-net.de>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: netdev@vger.kernel.org, Doug Berger <opendmb@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Zak Kemble <zakkemble@gmail.com>, Simon Horman <horms@kernel.org>,
Ryo Takakura <ryotkkr98@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: systemport: Fix missing phy-handle parsing for non-fixed PHYs
Date: Sun, 27 Sep 2026 21:39:57 +0200 [thread overview]
Message-ID: <36c5d3c209826028f2b12f738a8ee3a5@tipi-net.de> (raw)
In-Reply-To: <20260922222525.3992167-2-florian.fainelli@broadcom.com>
Hi Florian
On 23.9.2026 00:25, Florian Fainelli wrote:
> In bcm_sysport_probe(), priv->phy_dn is only initialized if the device
> tree node has a fixed-link configuration (of_phy_is_fixed_link). When
> connecting to a discrete MDIO-attached PHY referenced via 'phy-handle',
> priv->phy_dn remains NULL. This causes of_phy_connect() during
> bcm_sysport_open() to fail with -ENODEV since of_phy_find_device(NULL)
> returns NULL.
>
> Fix this by parsing 'phy-handle' via of_parse_phandle() and falling
> back
> to of_phy_is_fixed_link(). Ensure proper of_node_get() and
> of_node_put()
> refcounting lifecycle on both error unwinding and module remove paths.
>
> Assisted-by: LLM
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Change-Id: I714a31091e833c87fc766445b90cea53090fcec9
nit: remove gerrit trailer
> [...]
Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
Thanks,
Nicolai
next prev parent reply other threads:[~2026-09-27 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 22:25 [PATCH net-next 0/2] net: broadcom: Couple of minor changes Florian Fainelli
2026-09-22 22:25 ` [PATCH net-next 1/2] net: systemport: Fix missing phy-handle parsing for non-fixed PHYs Florian Fainelli
2026-09-27 19:39 ` Nicolai Buchwitz [this message]
2026-09-22 22:25 ` [PATCH net-next 2/2] net: bcmasp: remove duplicate MDA filter register definitions Florian Fainelli
2026-09-27 19:40 ` Nicolai Buchwitz
2026-09-27 10:49 ` [PATCH net-next 0/2] net: broadcom: Couple of minor changes Simon Horman
2026-09-29 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36c5d3c209826028f2b12f738a8ee3a5@tipi-net.de \
--to=nb@tipi-net.de \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=ryotkkr98@gmail.com \
--cc=zakkemble@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.