Re: [Buildroot] [PATCH v2 1/1] .github: add github action to automate PR handling

From: DongdongZhang <zhangdongdong@eswincomputing.com>
To: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	bonet@grenoble.cnrs.fr, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] .github: add github action to automate PR handling
Date: Tue, 9 Jul 2024 09:40:41 +0800 (GMT+08:00)	[thread overview]
Message-ID: <36db6d01.4d17.19095266b2d.Coremail.zhangdongdong@eswincomputing.com> (raw)
In-Reply-To: <20240708222933.5a0fd505@windsurf>

> -----原始邮件-----发件人:"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>发送时间:2024-07-09 04:29:33 (星期二)收件人:DongdongZhang <zhangdongdong@eswincomputing.com>抄送:"James Hilliard" <james.hilliard1@gmail.com>, bonet@grenoble.cnrs.fr, buildroot@buildroot.org主题:Re: [Buildroot] [PATCH v2 1/1] .github: add github action to automate PR handling
> 
> Hello,
> 
> On Mon, 8 Jul 2024 10:25:05 +0800 (GMT+08:00)
> DongdongZhang <zhangdongdong@eswincomputing.com> wrote:
> 
> > > Can probably just use a github script along these lines or something:
> > > https://github.com/sbabic/swupdate/blob/2024.05.2/.github/workflows/contributing.yml
> > > 
> > > probably also needs a conditional so it only runs on the one github repo:
> > > if: github.repository == ‘buildroot/buildroot’
> > >   
> > 
> > Hi, James,
> > In this scenario, I believe that using `dessant/repo-lockdown@v4` is more suitable 
> > than `actions/github-script@v5`. `dessant/repo-lockdown@v4` is specifically focused 
> > on repository lockdown functionality and has been widely used and validated. 
> > In contrast, while `actions/github-script@v5` is flexible, it requires more 
> > customization and maintenance work and a strong familiarity with JavaScript. 
> > To keep the process simple and stable, I have decided to continue 
> > using `dessant/repo-lockdown@v4`.
> 
> I do agree with you on this. However, you didn't reply to the second
> comment from James, on checking that the action only runs on the main
> buildroot repo, and not others. Indeed, we don't want people/companies
> forking our repo to have this PR lockdown action triggered.
> 
> Could you check this, and send an updated version of your patch?
> 
> Thanks a lot!
> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

Hello, Thomas.

I previously misunderstood James's response. Thanks to both James and your suggestions. 
I will update a patch version shortly to restrict the trigger condition to the 
repo `buildroot/buildroot`.

Thank you.

Dongdong
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot