Re: [PATCH mptcp-net 2/3] mptcp: subflow: no need to copy thmac during ulp_clone

[Matthieu Baerts <matttbe@kernel.org>]

On 21/08/2026 08:03, Matthieu Baerts wrote:
> Hello,
> 
> On 18/08/2026 19:55, Matthieu Baerts (NGI0) wrote:
>> 'thmac' is not used after that point.
>>
>> Indeed, subflow_ulp_clone() is called when the request on the passive
>> side is over, so when the truncated HMAC is no longer needed.
>>
>> Note that in case of SYN cookies, thmac will not be initialised. So
>> better to remove it to avoid a warning for reading uninitialised data.
> 
> Note that this modification is harmful in production, and that's why I
> didn't add a Fixes tag initially. But it is still important to have it
> to prevent warnings about reading uninitialised data. In this case, I
> think it is still good to add a Fixes tag not to have reports on stable.
> 
> Fixes: 263e1201a2c3 ("mptcp: consolidate synack processing.")
Or even from the beginning in fact:

Fixes: f296234c98a8 ("mptcp: Add handling of incoming MP_JOIN requests")

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.