All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: James Feist <james.feist@linux.intel.com>,
	openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH v2] valijson: Add recipe
Date: Wed, 10 Oct 2018 20:50:48 -0700	[thread overview]
Message-ID: <36dfdaa9-3867-20f2-33de-ef4e8bf51fc0@gmail.com> (raw)
In-Reply-To: <20181010231337.46391-1-james.feist@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1834 bytes --]

Hi James

On 10/10/18 4:13 PM, James Feist wrote:
> valijson is a header only c++ library for JSON
> schema validation.
> 
> Signed-off-by: James Feist <james.feist@linux.intel.com>
> ---
> 
> Changes since v1:
>     - Fixed license
>     - Simplified symlink
>     - Removed extra whitespace
> 
>  .../recipes-devtools/valijson/valijson_git.bb | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 meta-oe/recipes-devtools/valijson/valijson_git.bb
> 
> diff --git a/meta-oe/recipes-devtools/valijson/valijson_git.bb b/meta-oe/recipes-devtools/valijson/valijson_git.bb
> new file mode 100644
> index 000000000..e7edab646
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/valijson/valijson_git.bb
> @@ -0,0 +1,26 @@
> +SUMMARY = "Header-only C++ library for JSON Schema validation"
> +HOMEPAGE = "https://github.com/tristanpenman/valijson"
> +LICENSE = "BSD-2-Clause"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=015106c62262b2383f6c72063f0998f2"
> +
> +SRC_URI = "git://github.com/tristanpenman/valijson.git"
> +PV = "0.1+git${SRCPV}"
> +
> +SRCREV = "c2f22fddf599d04dc33fcd7ed257c698a05345d9"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit cmake
> +
> +EXTRA_OECMAKE = "-DINSTALL_HEADERS=1 -DBUILD_TESTS=0"
> +
> +# valijson is a header only C++ library, so the main package will be empty.
> +RDEPENDS_${PN}-dev = ""
> +
> +BBCLASSEXTEND = "native nativesdk"
> +
> +# valijson expects json.hpp where nlohmann-json_git.bb installs
> +# nlohmann/json.hpp, this allows usage via json.hpp
> +do_install_append() {
> +    ln -s nlohmann/json.hpp ${D}${includedir}/json.hpp
> +}

its better to install this symlink in nlohmann-json package recipe since
that will make sure that we do not have dangling symlinks in cases where
this dependencies are not together.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

      reply	other threads:[~2018-10-11  3:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 23:13 [meta-oe][PATCH v2] valijson: Add recipe James Feist
2018-10-11  3:50 ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36dfdaa9-3867-20f2-33de-ef4e8bf51fc0@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=james.feist@linux.intel.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.