From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1870BC8E2 for ; Wed, 21 Jun 2023 09:56:10 +0000 (UTC) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9A089B; Wed, 21 Jun 2023 02:56:08 -0700 (PDT) Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2b477e9d396so47609651fa.3; Wed, 21 Jun 2023 02:56:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687341367; x=1689933367; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7QfqFAs+LUbqWKQg3CDgDFj/Ai/EFvoPAUEVH6zEuh0=; b=RwawYWuTKJn64CRDe1NcFPPtAeUHodvFBD5epWUqqbkQqAWvS64peIcriBCCT6Rxvf VVL+eIEeKbAmT14URvYpdcknGiLqjzVhGbJShDfg7kMjc4KPBDadW5ivGhmnxXku/G37 Y8H+MP3dnv004WodMe7MAQN3cCuRLxrbLHTXgvHSpRkciW8+h7lCGTw4zFL16TmFn+Pc Z2TBUPmjVywBWaEbdoeNb9BJ+9K+qWCR/fduJaYeb7pDb+0Xbp9FnWqLC+nTUkvPKbwV PFAgYx9uoG+w5mdcyWNvOZFaPbloKR05Cbf6fclHSo+jALMug2ZK3vBsEa7VwlEk9tOO JLJQ== X-Gm-Message-State: AC+VfDxTZDpe2t8kPROKzxs2wcnUqn/oTex+3diNNImPZnvivljUTVPJ s09IUcTzBWaE70RAHKAvTII= X-Google-Smtp-Source: ACHHUZ4GQBsPStePkHDKNlzEaMWr+Bp+ebV1Ur4N9HjkC8j8Qd1kDy/CWY6Orh1D9sVCHniBDQ4DcQ== X-Received: by 2002:a2e:9846:0:b0:2b4:737c:e316 with SMTP id e6-20020a2e9846000000b002b4737ce316mr7027828ljj.14.1687341366842; Wed, 21 Jun 2023 02:56:06 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id m20-20020a7bca54000000b003f80e81705asm4477120wml.45.2023.06.21.02.56.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 02:56:06 -0700 (PDT) Message-ID: <36fae2b0-4cd2-58b5-cc12-9abdd5ce235b@kernel.org> Date: Wed, 21 Jun 2023 11:56:03 +0200 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init To: Joel Granados , mcgrof@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Theodore Ts'o , "Jason A. Donenfeld" , Greg Kroah-Hartman , Juergen Gross , Stefano Stabellini , Benjamin LaHaise , Alexander Viro , Christian Brauner , Jeff Layton , Chuck Lever , Jan Kara , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Peter Zijlstra , Will Deacon , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" Cc: "H. Peter Anvin" , Oleksandr Tyshchenko , Amir Goldstein , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng , John Ogness , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , Mark Rutland , Miaohe Lin , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org References: <20230621091000.424843-1-j.granados@samsung.com> <20230621091000.424843-9-j.granados@samsung.com> Content-Language: en-US From: Jiri Slaby In-Reply-To: <20230621091000.424843-9-j.granados@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 21. 06. 23, 11:09, Joel Granados wrote: > In order to remove the end element from the ctl_table struct arrays, we > explicitly define the size when registering the targes. We add a size > argument to the register_sysctl_init call and pass an ARRAY_SIZE for all > the callers. Hi, I am missing here (or in 00/00) _why_ you are doing that. Is it by a chance those saved 9k? I hope not. thanks, -- js suse labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD31CEB64DA for ; Wed, 28 Jun 2023 15:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3iTUP+Byr8vGd0qWRRVSwHB/wpQYveB0+DXqtXpZ2n0=; b=qivpgOzomEd2Qq FWgvuTXPruBjPsAYaA9wELrbq91pimnKsjUmUZPou40kh/Ck8FoY8DT37QO7VyHPm16gbBYd5k9Ly yN1Adu6FXhhHU0kDunDnxwvZiDaYQ+WhW9s4rT2zNU6u1ZLDCIK+K9LjWZWCnl0AhzWaaIqoxrNCP Smlo58BNIDAp3QyZ+mmsF2DNPBUlsmgZiMZ9aQxa1DOT9Xj2zD+M1lYq67xxoMjPbHcZJgN+edo+b RkLuAhyurPrsUurSP8dtYQcSmb/Jvq6CQPvA+arJW0U1wKuQZjmbE7Ijx9Nv1rrLJVCFv4oSwLp2J bRT9RspG3s9lovW09m0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEWuR-00Fx3G-1o; Wed, 28 Jun 2023 15:16:43 +0000 Received: from mail-lj1-f175.google.com ([209.85.208.175]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBuZN-00Dwzu-1U for kexec@lists.infradead.org; Wed, 21 Jun 2023 09:56:12 +0000 Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2b477e9d396so47609601fa.3 for ; Wed, 21 Jun 2023 02:56:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687341367; x=1689933367; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7QfqFAs+LUbqWKQg3CDgDFj/Ai/EFvoPAUEVH6zEuh0=; b=lq2XYS4jaA7SYZUN1onMpvSRChD+TvtOIFNWYGY+pQVUU/1Lrc96DduZE7k5PnrGPV 4EWV8E3+Oe8y2dwYkaJUA7r+FnWZI8dOoMdbhyDmzqkikfRui7ftuSaGFT1czIiJIXiD IJShxAl29bCG+WkFVX42RKBfOn6SXQ7J6jVlAuh3zY9Ih4W33bHwJgXRNEfbLY4tcNYY Axojj/cTPDFFCdHkqCIXuv/+0NG6jbXmUHYuhreEjyTn4QwCL2aEBj+cUhs0f+lij2P3 vGrnUDO/jfbV68JweP2RVOWgDIkkem9XvKjmOeF79p/N3QrfvsJ/DPFg1NDoAHSm5Drw y9ig== X-Gm-Message-State: AC+VfDwjC9PtHFIVCeEJG4po0GHwyPqssss1ejhoUzx+MOQJI0md/gHh p2vJgnGIcqjPTcAbLRHVF90= X-Google-Smtp-Source: ACHHUZ4GQBsPStePkHDKNlzEaMWr+Bp+ebV1Ur4N9HjkC8j8Qd1kDy/CWY6Orh1D9sVCHniBDQ4DcQ== X-Received: by 2002:a2e:9846:0:b0:2b4:737c:e316 with SMTP id e6-20020a2e9846000000b002b4737ce316mr7027828ljj.14.1687341366842; Wed, 21 Jun 2023 02:56:06 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id m20-20020a7bca54000000b003f80e81705asm4477120wml.45.2023.06.21.02.56.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 02:56:06 -0700 (PDT) Message-ID: <36fae2b0-4cd2-58b5-cc12-9abdd5ce235b@kernel.org> Date: Wed, 21 Jun 2023 11:56:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init To: Joel Granados , mcgrof@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Theodore Ts'o , "Jason A. Donenfeld" , Greg Kroah-Hartman , Juergen Gross , Stefano Stabellini , Benjamin LaHaise , Alexander Viro , Christian Brauner , Jeff Layton , Chuck Lever , Jan Kara , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Peter Zijlstra , Will Deacon , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" Cc: "H. Peter Anvin" , Oleksandr Tyshchenko , Amir Goldstein , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng , John Ogness , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , Mark Rutland , Miaohe Lin , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org References: <20230621091000.424843-1-j.granados@samsung.com> <20230621091000.424843-9-j.granados@samsung.com> Content-Language: en-US From: Jiri Slaby In-Reply-To: <20230621091000.424843-9-j.granados@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_025609_499228_D979D6DD X-CRM114-Status: GOOD ( 12.52 ) X-Mailman-Approved-At: Wed, 28 Jun 2023 08:16:38 -0700 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On 21. 06. 23, 11:09, Joel Granados wrote: > In order to remove the end element from the ctl_table struct arrays, we > explicitly define the size when registering the targes. We add a size > argument to the register_sysctl_init call and pass an ARRAY_SIZE for all > the callers. Hi, I am missing here (or in 00/00) _why_ you are doing that. Is it by a chance those saved 9k? I hope not. thanks, -- js suse labs _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec