From: David Ahern <dsahern@gmail.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH RESEND net-next] netlink: add tracepoint at NL_SET_ERR_MSG
Date: Tue, 2 Feb 2021 09:16:28 -0700 [thread overview]
Message-ID: <37002645-e09b-1067-eda6-ee30155afe47@gmail.com> (raw)
In-Reply-To: <20210202123007.GE3288@horizon.localdomain>
On 2/2/21 5:30 AM, Marcelo Ricardo Leitner wrote:
>
> Also, if the message is a common one, one may not be able to easily
> distinguish them. Ideally this shouldn't happen, but when debugging
> applications such as OVS, where lots of netlink requests are flying,
> it saves us time. I can, for example, look at a perf capture and
> search for cls_flower or so. Otherwise, it will all show up as
> "af_netlink: <err_msg>"
Modules should be using the NL_SET_ERR_MSG_MOD variant, so the message
would be ""af_netlink: cls_flower: <err_msg>"
I get the value in knowing the call site, so not arguing against that.
Just hoping that your experience matches theory.
next prev parent reply other threads:[~2021-02-02 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 18:12 [PATCH RESEND net-next] netlink: add tracepoint at NL_SET_ERR_MSG Marcelo Ricardo Leitner
2021-02-02 1:34 ` Jakub Kicinski
2021-02-02 12:30 ` Marcelo Ricardo Leitner
2021-02-02 16:16 ` David Ahern [this message]
2021-02-02 19:30 ` Marcelo Ricardo Leitner
2021-02-03 22:31 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37002645-e09b-1067-eda6-ee30155afe47@gmail.com \
--to=dsahern@gmail.com \
--cc=kuba@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.