From: David Howells <dhowells@redhat.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: dhowells@redhat.com, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
Josh Boyer <jwboyer@fedoraproject.org>,
keyrings@vger.kernel.org
Subject: Re: [PATCH 6/6] efi: Add EFI_SECURE_BOOT bit [ver #2]
Date: Wed, 23 Nov 2016 10:07:21 +0000 [thread overview]
Message-ID: <3710.1479895641@warthog.procyon.org.uk> (raw)
In-Reply-To: <20161123092735.GA2071@wunner.de>
Lukas Wunner <lukas@wunner.de> wrote:
> > +#ifdef CONFIG_EFI
> > + if (boot_params.secure_boot) {
> > + set_bit(EFI_SECURE_BOOT, &efi.flags);
> > + pr_info("Secure boot enabled\n");
> > + }
> > +#endif
> > +
>
> Section 20 of Documentation/CodingStyle recommends IS_ENABLED()
> instead of #ifdef.
The problem is this:
arch/x86/include/asm/bitops.h:75: undefined reference to `efi'
To quote section 20: "... Thus, you still have to use an #ifdef if the code
inside the block references symbols that will not exist if the condition is
not met."
> Also, CONFIG_EFI_STUB might be more apt than CONFIG_EFI.
Other stuff in the same function is contingent on CONFIG_EFI. EFI_STUB is to
do with how the thing can be booted, I think - not whether EFI support is
enabled.
David
next prev parent reply other threads:[~2016-11-23 10:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 0:22 [PATCH 0/6] efi: Pass secure boot mode to kernel [ver #2] David Howells
2016-11-23 0:22 ` [PATCH 1/6] x86/efi: Allow invocation of arbitrary runtime services " David Howells
[not found] ` <147986054870.13790.8640536414645705863.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2016-11-23 0:22 ` [PATCH 2/6] arm/efi: " David Howells
2016-11-23 0:22 ` David Howells
2016-11-23 9:34 ` David Howells
2016-11-23 10:35 ` Ard Biesheuvel
2016-11-23 11:51 ` David Howells
2016-11-23 10:27 ` Mark Rutland
2016-11-23 11:46 ` David Howells
[not found] ` <6125.1479901598-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2016-11-23 13:38 ` Mark Rutland
2016-11-23 13:38 ` Mark Rutland
2016-11-23 0:22 ` [PATCH 3/6] efi: Add SHIM and image security database GUID definitions " David Howells
2016-11-23 0:22 ` David Howells
2016-11-23 0:22 ` [PATCH 4/6] efi: Get the secure boot status " David Howells
2016-11-23 9:31 ` Lukas Wunner
2016-11-23 9:53 ` David Howells
2016-11-23 10:10 ` Lukas Wunner
[not found] ` <147986057768.13790.3027173260868896792.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2016-11-23 10:47 ` Mark Rutland
2016-11-23 10:47 ` Mark Rutland
2016-11-23 11:25 ` David Howells
2016-11-23 13:42 ` Mark Rutland
2016-11-23 14:13 ` David Howells
2016-11-23 14:24 ` Mark Rutland
2016-11-23 14:55 ` David Howells
[not found] ` <2794.1479912933-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2016-11-29 18:11 ` Matthew Garrett
2016-11-29 18:11 ` Matthew Garrett
2016-11-30 16:51 ` David Howells
2016-11-30 16:51 ` David Howells
2016-11-23 0:23 ` [PATCH 5/6] efi: Disable secure boot if shim is in insecure mode " David Howells
[not found] ` <147986058486.13790.8455439853105793460.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2016-11-23 13:38 ` Mark Rutland
2016-11-23 13:38 ` Mark Rutland
2016-11-23 0:23 ` [PATCH 6/6] efi: Add EFI_SECURE_BOOT bit " David Howells
2016-11-23 9:27 ` Lukas Wunner
2016-11-23 10:07 ` David Howells [this message]
2016-11-23 10:09 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3710.1479895641@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=jwboyer@fedoraproject.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.